Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code and update specs #86

Merged
merged 24 commits into from
Nov 30, 2021
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
43c22ed
Removed overly convoluted code I added before, updated spec tests, re…
johnmccrae Oct 6, 2021
5137ddc
Final commit?
johnmccrae Nov 8, 2021
d515a45
Final commit? Closer!
johnmccrae Nov 8, 2021
f9ec50c
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 23, 2021
66a402e
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 23, 2021
01c88d0
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 23, 2021
f5eedd1
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 23, 2021
d5813f8
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 23, 2021
7f0d57a
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 24, 2021
db2b465
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 24, 2021
9a98a88
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 24, 2021
ea6a3e6
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 24, 2021
4906394
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 24, 2021
7991023
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 24, 2021
4065739
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 24, 2021
fef2711
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 24, 2021
6c6dca8
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 24, 2021
edd6271
Properly accounted for Linux/Mac style thumbprint structures
johnmccrae Nov 24, 2021
05e6c1e
Properly accounted for Linux/Mac style thumbprint structures and upda…
johnmccrae Nov 24, 2021
ff0e9d5
Refactored the tests to accept cert thumbprints with spaces and colon…
johnmccrae Nov 25, 2021
e146fce
Refactored the tests to accept cert thumbprints with spaces and colon…
johnmccrae Nov 25, 2021
ae1ac69
Updated the GEMFILE to remove unnecessary dependency
johnmccrae Nov 29, 2021
1e84d69
Updated the code to remove the shell_out mixin
johnmccrae Nov 29, 2021
bf4ae54
Removed unnecessary comments and refactored Functional test
johnmccrae Nov 30, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ source "https://rubygems.org"
gemspec

gem "mixlib-shellout", "< 3.2.3"
johnmccrae marked this conversation as resolved.
Show resolved Hide resolved
gem "chef-powershell", ">= 1.0.4"

if Gem.ruby_version.to_s.start_with?("2.5")
johnmccrae marked this conversation as resolved.
Show resolved Hide resolved
# 16.7.23 required ruby 2.6+
Expand Down