Added .serialize() support. Fixes #69
#827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was initially opened in #632 over 1 year ago. Can we please land it? |
|
@twolfson Sorry for the delay – and thanks for implementing the feature :) |
|
woot, thanks for landing this =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally opened as #632 but @twolfson lost write access to the source repo and there was a merge conflict so we resolved it all in this PR
Now that #631 is implemented, we can add
.serialize()support. Unfortunately, this comes with adding$.param().$.paramhas a second half that.serialize()doesn't leverage (see itselsestatement). I am not sure whether we want to add this/test it, or drop it and make$.paraminternal only for now.In this PR:
.serialize()support http://api.jquery.com/serialize/.serialize()