Added .serialize() support. Fixes #69

[twolfson]

Now that #631 is implemented, we can add .serialize() support. Unfortunately, this comes with adding $.param(). $.param has a second half that .serialize() doesn't leverage (see its else statement). I am not sure whether we want to add this/test it, or drop it and make $.param internal only for now.

In this PR:

• Added .serialize() support http://api.jquery.com/serialize/
• Added tests for .serialize()

[coveralls]

Coverage decreased (-1.39%) when pulling cc71303 on underdogio:dev/add.serialize.method.sqwished into f864e39 on cheeriojs:master.

[twolfson]

I have caught up this PR with the changes from landing #631 to master. It looks like I was wreckless when adding tests (i.e. didn't test all of jQuery's functionality) and was focused on using serialize to get a query string. I will revisit this later.

[coveralls]

Coverage decreased (-1.42%) to 97.2% when pulling c855375 on underdogio:dev/add.serialize.method.sqwished into ccd9369 on cheeriojs:master.

[coveralls]

Coverage increased (+0.01%) to 98.62% when pulling ddd4fd0 on underdogio:dev/add.serialize.method.sqwished into ccd9369 on cheeriojs:master.

[twolfson]

I have chosen to take the shorter path and stripped out everything from jQuery.param that is irrelevant to .serialize(). The result is a much smaller PR. There is 1 line I haven't been able to figure out how to test which is:

var value = data.value == null ? '' : data.value;

I cannot seem to find a case when data.value == null. .serializeArray() returns no data for val == null.

cheerio/lib/api/forms.js

Line 38 in ccd9369

return null;

[fb55]

@twolfson I can't think of a case where data.value is null either, just drop the line. The rest LGTM.

[twolfson]

I have updated the PR to ditch the null check.

[coveralls]

Coverage increased (+0.01%) to 98.62% when pulling dcd6680 on underdogio:dev/add.serialize.method.sqwished into f71387e on cheeriojs:master.

[mh166]

@twolfson, @fb55: is there any news on this PR? It would be very useful to me in my current project. 👍

[twolfson]

There's a merge conflict and I no longer have write access to the source repo. I'm going to close and reopen this PR.

@mh166 You can point to a git URL for dependencies in npm:

https://docs.npmjs.com/files/package.json#urls-as-dependencies

"cheerio": "git://github.com/underdogio/cheerio#dcd66809"

[twolfson]

I have opened the replacement PR #827

[mh166]

Thanks! It's greatly appreciated!