Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for passing non-string values to .html or .text #704

Merged
merged 2 commits into from
Feb 1, 2016
Merged

Fix for passing non-string values to .html or .text #704

merged 2 commits into from
Feb 1, 2016

Conversation

Rycochet
Copy link
Contributor

Fix for #703

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.61% when pulling a0ff74c on Rycochet:master into 2e82d09 on cheeriojs:master.

@jugglinmike
Copy link
Member

Thanks for the patch! Would you mind adding tests for this change?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.61% when pulling 2dc84d5 on Rycochet:master into 2e82d09 on cheeriojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.61% when pulling 2dc84d5 on Rycochet:master into 2e82d09 on cheeriojs:master.

fb55 added a commit that referenced this pull request Feb 1, 2016
@fb55
Merge pull request #704 from Rycochet/master
9d98bd7 
Fix for passing non-string values to .html or .text
@fb55 fb55 merged commit 9d98bd7 into cheeriojs:master Feb 1, 2016
@fb55
Copy link
Member

fb55 commented Feb 1, 2016

@Rycochet Sorry for the delay – and thanks!

@fb55 fb55 mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rycochet @coveralls @jugglinmike @fb55