Merge pull request #704 from Rycochet/master

Fix for passing non-string values to .html or .text
cheeriojs · Feb 1, 2016 · 9d98bd7 · 9d98bd7
2 parents 1b9c5c9 + 2dc84d5
commit 9d98bd7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/api/manipulation.js b/lib/api/manipulation.js
@@ -371,7 +371,7 @@ exports.html = function(str) {
       el.next = el.prev = el.parent = null;
     });
 
-    var content = str.cheerio ? str.clone().get() : evaluate(str, opts);
+    var content = str.cheerio ? str.clone().get() : evaluate('' + str, opts);
 
     updateDOM(content, el);
   });
@@ -402,7 +402,7 @@ exports.text = function(str) {
     });
 
     var elem = {
-      data: str,
+      data: '' + str,
       type: 'text',
       parent: el,
       prev: null,

diff --git a/test/cheerio.js b/test/cheerio.js
@@ -227,6 +227,18 @@ describe('cheerio', function() {
     expect($empty.each).to.be($.prototype.each);
   });
 
+  it('should set html(number) as a string', function() {
+    var $elem = $('<div>');
+    $elem.html(123);
+    expect(typeof $elem.text()).to.equal('string');
+  });
+
+  it('should set text(number) as a string', function() {
+    var $elem = $('<div>');
+    $elem.text(123);
+    expect(typeof $elem.text()).to.equal('string');
+  });
+
   describe('.load', function() {
 
     it('should generate selections as proper instances', function() {