Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #32

Closed
rnveach opened this issue Jun 16, 2017 · 6 comments
Closed

Main #32

rnveach opened this issue Jun 16, 2017 · 6 comments
Assignees

Comments

@rnveach
Copy link
Member

rnveach commented Jun 16, 2017

We need a main class that users will use to access and run 'regression-tool'.

It needs to take in custom parameters, validate the parameters, and use those values to execute the tool.
If any parameters are wrongly entered, we need to give an informative error message and exit with non-zero code.
If an exception happens in any component, we should rethrow it all the way up to the Main class and display it to the user.

What kind of parameters will we accept? Which are required, which can be optional, and what will be the default values of the optional ones?
We will need a type of help menu, to display to users the list of parameters and their brief descriptions and anything else they need to know to use them correctly.

Blocked by Issue #19, #20, #21 .

@Luolc
Copy link
Contributor

Luolc commented Jul 5, 2017

Arguments we found by now:

  • repository path: the path of the repository. Required.
  • branch name: the name of the PR branch. Required.

More arguments are need in report component. Those would depend on the discussion in #21

For report:

  • checkstyle-tester path: the path of the contribution/checkstyle-tester folder. Required.

@rnveach
Copy link
Member Author

rnveach commented Jul 12, 2017

@Luolc Once we are finished with all components up to and including generating config, we need to start this.
@romani wants a simple test program that will generate configs for users.

Other components may take a back seat and we may start working on expanding what is getting placed into the generated config file.

@rnveach
Copy link
Member Author

rnveach commented Jul 20, 2017

@Luolc Please start this.
Config generation only should be some type of special option. It should not be the default.

@Luolc
Copy link
Contributor

Luolc commented Jul 20, 2017

@rnveach

Config generation only should be some type of special option.

Do you mean that we have two options: 1. generate config and report 2. only generate config ?

@rnveach
Copy link
Member Author

rnveach commented Jul 20, 2017

Do you mean that we have two options: 1. generate config and report

1 should be the default as this will be the most common case when our utility is fully functional. Users shouldn't need to give an option to do this, it should be default.
Not doing report should be some kind of a special option like, -dontGenerateReport or -stopAfterGenerateConfig.
We are not a configuration generation tool, we are a full regression tool. So our default behavior should be just that.

Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 20, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 20, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 21, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 23, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 24, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 24, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 25, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 26, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 26, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 27, 2017
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 27, 2017
rnveach pushed a commit that referenced this issue Jul 27, 2017
@rnveach
Copy link
Member Author

rnveach commented Jul 27, 2017

Issues have been created for remaining work, so I am closing this

@rnveach rnveach closed this as completed Jul 27, 2017
@Luolc Luolc mentioned this issue Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants