Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration Component #20

Closed
Luolc opened this issue Jun 11, 2017 · 4 comments
Closed

Configuration Component #20

Luolc opened this issue Jun 11, 2017 · 4 comments
Assignees
@Luolc

Comments

@Luolc
Copy link
Contributor

Luolc commented Jun 11, 2017

Taken from #2
configuration should be given only the information it needs to create the configuration(s). This would be the list of modules and the specified properties.
@Luolc Luolc mentioned this issue Jun 11, 2017
Closed
@rnveach rnveach mentioned this issue Jun 16, 2017
Closed
Luolc added a commit to Luolc/regression-tool that referenced this issue Jun 29, 2017
@Luolc
Issue checkstyle#20: Configuration Component
7a09260
Luolc added a commit to Luolc/regression-tool that referenced this issue Jun 29, 2017
@Luolc
Issue checkstyle#20: Configuration Component
212be47
@Luolc Luolc mentioned this issue Jun 29, 2017
Merged
Luolc added a commit to Luolc/regression-tool that referenced this issue Jun 29, 2017
@Luolc
Issue checkstyle#20: Configuration Component
b25430c
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 1, 2017
@Luolc
Issue checkstyle#20: Configuration Component
4d2cc44
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 1, 2017
@Luolc
Issue checkstyle#20: Configuration Component
6044d29
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 3, 2017
@Luolc
Issue checkstyle#20: Configuration Component
12f42a9
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 3, 2017
@Luolc
Issue checkstyle#20: Configuration Component
8532b26
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 3, 2017
@Luolc
Issue checkstyle#20: Configuration Component
62752ef
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 3, 2017
@Luolc
Issue checkstyle#20: Configuration Component
75c5740
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 4, 2017
@Luolc
Issue checkstyle#20: Configuration Component
e637302
Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 4, 2017
@Luolc
Issue checkstyle#20: Configuration Component
16c4dbd
@rnveach
Copy link
Member

rnveach commented Jul 4, 2017

@Luolc The following issue in Checkstyle must be completed for us to continue with 1 configuration with all modules: checkstyle/checkstyle#4607

@Luolc
Copy link
Contributor Author

Luolc commented Jul 4, 2017

@rnveach OK. I am looking on that.

Luolc added a commit to Luolc/regression-tool that referenced this issue Jul 5, 2017
@Luolc
Issue checkstyle#20: Configuration Component
22a277a
rnveach pushed a commit that referenced this issue Jul 5, 2017
@Luolc @rnveach
Issue #20: Configuration Component
befb36a
@rnveach
Copy link
Member

rnveach commented Jul 5, 2017

Issue is in our repo is done but we must finish issue in Checkstyle (checkstyle/checkstyle#4607). I will leave this open to remind us of this.

@rnveach
Copy link
Member

rnveach commented Aug 10, 2017

Fix in checkstyle was merged.

@rnveach rnveach closed this as completed Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luolc Luolc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rnveach @Luolc