Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: travis-ci check compression #166

Merged
merged 7 commits into from
Dec 2, 2019
Merged

fix: travis-ci check compression #166

merged 7 commits into from
Dec 2, 2019

Conversation

chdsbd
Copy link
Owner

@chdsbd chdsbd commented Aug 24, 2019 •
edited
Loading

This is blocked until I can find all the possible status checks that map to continuous-integration/travis-ci. I've opened an issue with GitHub, so hopefully they will have information.

fixes #163

@chdsbd chdsbd added the automerge Mark PR for auto merge by Kodiak label Aug 24, 2019
@chdsbd chdsbd mentioned this pull request Aug 24, 2019
Closed
@staabm
Copy link
Contributor

staabm commented Aug 25, 2019 •
edited
Loading

As mentioned in the issue I try the more up 2 date travis integration.
In case this works it might be good enough to document this as a „known issue“ instead of complicating your code base ... its your call

chdsbd added a commit that referenced this pull request Aug 25, 2019
@chdsbd
doc: deprecated TravisCI commit status support
b0c2487 
Kodiak does not support using the deprecated Travis-CI commit status updates for branch protection. Instead, users should upgrade to the newer GitHub Checks based solution.

Related #163, #166
@chdsbd chdsbd mentioned this pull request Aug 25, 2019
Merged
kodiakhq bot pushed a commit that referenced this pull request Aug 25, 2019
@chdsbd @kodiakhq
doc: deprecated TravisCI commit status support (#167)
2db9a27 
Kodiak does not support using the deprecated Travis-CI commit status updates for branch protection. Instead, users should upgrade to the newer GitHub Checks based solution.

Related #163, #166
@chdsbd
Copy link
Owner Author

chdsbd commented Oct 26, 2019

I talked with GitHub support a while back and they said there is handling just for the case of continuous-integration/travis-ci/{pr,push} => continuous-integration/travis-ci. That said I don't think it's worth adding this complication when the check is deprecated by travis-ci.

@chdsbd chdsbd closed this Oct 26, 2019
@chdsbd
Copy link
Owner Author

chdsbd commented Dec 2, 2019

Looking at the logs on Kodiak this does appear to affect people regularly, so I'm going to fix it.

@chdsbd chdsbd reopened this Dec 2, 2019
@chdsbd chdsbd requested a review from sbdchd December 2, 2019 03:29
@chdsbd chdsbd changed the title wip: fix: travis-ci check compression fix: travis-ci check compression Dec 2, 2019
@kodiakhq kodiakhq bot merged commit 9981add into master Dec 2, 2019
@kodiakhq kodiakhq bot deleted the fix/163 branch December 2, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbdchd sbdchd sbdchd approved these changes

Assignees
No one assigned
Labels
automerge Mark PR for auto merge by Kodiak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR doesnt get merged
3 participants
@chdsbd @staabm @sbdchd