Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR doesnt get merged #163

Closed
staabm opened this issue Aug 21, 2019 · 4 comments · Fixed by #166
Closed

PR doesnt get merged #163

staabm opened this issue Aug 21, 2019 · 4 comments · Fixed by #166
Labels
bug Something isn't working

Comments

@staabm
Copy link
Contributor

staabm commented Aug 21, 2019

sometimes a PR doesnt get merged by kodiak. in this cases kodiak states that it is waiting for 'travis ci' to get green.

but the ci checks already returned green.

this happened e.g. in the following PRs:
redaxo/redaxo#2818
redaxo/redaxo#2856

it works in 95% of our PRs as intended but sometimes doesnt... we werent able to identify why yet

see where all checks are already green but kodiak is still waiting for travis-ci:
grafik

we merged the PRs manually after waiting ~30min.

@staabm staabm added the bug Something isn't working label Aug 21, 2019
@chdsbd
Copy link
Owner

chdsbd commented Aug 21, 2019

I see the issue. Github branch protection rules compact for continuous-integration/travis-ci/{pr,pull,build,etc} into continuous-integration/travis-ci. This only happens for continuous-integration/travis-ci as far as I can tell.

The fix is pretty straight forward. Thanks for reporting this.

@chdsbd
Copy link
Owner

chdsbd commented Aug 24, 2019

I've opened an issue with GitHub because I think there is some undocumented behavior here on GitHub's side. I have a test case in #166 based on some experimentation with the GitHub api.

It appears that this only affects travis-ci and certain travis-ci checks.

Here are some examples of status check truncation behavior

continuous-integration/travis-ci/push => continuous-integration/travis-ci
continuous-integration/travis-ci/pr => continuous-integration/travis-ci
continuous-integration/travis-ci/deploy => continuous-integration/travis-ci/deploy

continuous-integration/example-ci/push => continuous-integration/example-ci/push
continuous-integration/example-ci/pr => continuous-integration/example-ci/pr

I'm not sure of all the travis-ci checks that truncate, I only have continuous-integration/travis-ci/push and continuous-integration/travis-ci/pr at the moment. Hopefully GitHub support will be able to provide more guidance on this odd behavior.

@chdsbd
Copy link
Owner

chdsbd commented Aug 25, 2019

I think based on this issue travis-ci#9618, if you want an immediate solution you could move to the newer Checks based api, which I believe won't have this problematic behavior.

@staabm
Copy link
Contributor Author

staabm commented Aug 25, 2019

Thx for the pointer. i just deleted the old services integrations. Lets see if this fixes the problem
//cc @gharlan

chdsbd added a commit that referenced this issue Aug 25, 2019
Kodiak does not support using the deprecated Travis-CI commit status updates for branch protection. Instead, users should upgrade to the newer GitHub Checks based solution.

Related #163, #166
kodiakhq bot pushed a commit that referenced this issue Aug 25, 2019
Kodiak does not support using the deprecated Travis-CI commit status updates for branch protection. Instead, users should upgrade to the newer GitHub Checks based solution.

Related #163, #166
@kodiakhq kodiakhq bot closed this as completed in #166 Dec 2, 2019
kodiakhq bot pushed a commit that referenced this issue Dec 2, 2019
This is blocked until I can find all the possible status checks that map to `continuous-integration/travis-ci`. I've opened an issue with GitHub, so hopefully they will have information.

fixes #163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants