Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout and user-label config key #12

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

addyess
Copy link
Member

@addyess addyess commented Nov 19, 2024

Overview

Adds new arguments to the LabelMaker library to support

  • a flexible config key name for the labels on the unit
  • a means to change the timeout for failed labellings

@addyess addyess force-pushed the KU-2098/label-maker-options branch 4 times, most recently from 3cd85ba to 97f100b Compare November 20, 2024 04:14
ops/charms/node_base.py Outdated Show resolved Hide resolved
ops/charms/node_base.py Outdated Show resolved Hide resolved
ops/charms/node_base.py Outdated Show resolved Hide resolved
ops/charms/node_base.py Outdated Show resolved Hide resolved
ops/charms/node_base.py Outdated Show resolved Hide resolved
try:
from typing import Annotated, TypeAlias

PositiveInt: TypeAlias = Annotated[int, lambda x: x > 0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of annotated metadata!

Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docstring!

@addyess addyess merged commit a14d685 into main Nov 20, 2024
7 checks passed
@addyess addyess deleted the KU-2098/label-maker-options branch November 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants