Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename charm configurations to include new prefixes #179

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Nov 20, 2024

Applicable spec: KU-2098

Overview

Add bootstrap- and node- prefixes to charm config

Rationale

Provides better namespacing to charm options

Library Changes

Needs updated library changes in

Checklist

@addyess addyess requested a review from a team as a code owner November 20, 2024 04:35
@addyess addyess force-pushed the KU-2098/bootstrap-configuration-options branch from 1881742 to 0bdadc3 Compare November 20, 2024 21:11
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks a lot @addyess! LGTM. Just a minor comment/question.

charms/worker/k8s/src/charm.py Show resolved Hide resolved
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Test coverage for ac6ffe8

coverage-report: install_deps /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> python -I -m pip install 'coverage[toml]'
coverage-report: commands[0] /home/runner/work/k8s-operator/k8s-operator/charms/worker/k8s> coverage report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
lib/charms/k8s/v0/k8sd_api_manager.py     270     29    89%
src/charm.py                              463    240    48%
src/cloud_integration.py                   80      3    96%
src/containerd.py                         140     16    89%
src/cos_integration.py                     33     12    64%
src/events/update_status.py                48     10    79%
src/inspector.py                           40      3    92%
src/kube_control.py                        39     31    21%
src/literals.py                             1      0   100%
src/protocols.py                           16      3    81%
src/reschedule.py                          77      4    95%
src/snap.py                               165     10    94%
src/token_distributor.py                  174    103    41%
src/upgrade.py                             31      1    97%
-----------------------------------------------------------
TOTAL                                    1577    465    71%
coverage-report: OK (1.20=setup[1.00]+cmd[0.20] seconds)
congratulations :) (1.24 seconds)

Static code analysis report

Run started:2024-11-21 23:22:47.373413

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 3387
  Total lines skipped (#nosec): 13
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@addyess addyess merged commit fb5397b into main Nov 22, 2024
61 checks passed
@addyess addyess deleted the KU-2098/bootstrap-configuration-options branch November 22, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants