Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support for specifing javaHome when creating java experiments #552

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

xcaspar
Copy link
Member

@xcaspar xcaspar commented Aug 2, 2021

Signed-off-by: xcaspar [email protected]

Describe what this PR does / why we need it

Does this pull request fix one issue?

chaosblade#551

Describe how you did it

Add javaHome in java experiments and parse it when creating.

Describe how to verify it

blade c jvm cpufullload --javaHome /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home --process tomcat --refresh 

Special notes for reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants