add a debug mode env that plugin failure will abort model generation #393
Conversation
hdoan741
changed the base branch from
master
to
2935b3f5a93de4caecd3873b09c009e75700b134
Pull Request Branch: manhhung741/add_a_debug_mode_env_that_plugin_failure Pull Request Link: #393
hdoan741
force-pushed
the
manhhung741/add_a_debug_mode_env_that_plugin_failure
branch
from
e9f1cf6
to
b11a41c
Compare
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
=======================================
Coverage 97.24% 97.24%
=======================================
Files 138 138
Lines 3264 3265 +1
=======================================
+ Hits 3174 3175 +1
Misses 90 90
Continue to review full report at Codecov.
|
Pull Request Branch: manhhung741/add_a_debug_mode_env_that_plugin_failure Pull Request Link: #393
hdoan741
changed the base branch from
2935b3f5a93de4caecd3873b09c009e75700b134
to
master
hdoan741
force-pushed
the
manhhung741/add_a_debug_mode_env_that_plugin_failure
branch
from
b11a41c
to
7a14af7
Compare
| ). | ||
| void | ||
| } | ||
| def run_plugins(plugins, generator, allow_failure: true) | ||
| def run_plugins(plugins, generator) | ||
| allow_failure = ENV["SBR_DEBUG_MODE"] == "true" |
There was a problem hiding this comment.
👋 Unsolicited and post merge feedback, but I think this might be backwards. I think you probably want to allow failures if the ENV VAR is NOT set to true
I think as is this will change the default (no env var) case from allowing failure to NOT allowing failure
I came across this while trying to debug some generation I had, slightly unfortunately in the version with debug mode I no longer get the error so I can't confirm my suspicion that this might be backwards!
No description provided.