Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Add a debug mode when running rails_rbi:models #372

Open
hdoan741 opened this issue Aug 17, 2020 · 1 comment
Open

Add a debug mode when running rails_rbi:models #372

hdoan741 opened this issue Aug 17, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@hdoan741
Copy link
Contributor

Describe the issue:

When running rails_rbi:models, if a plugin runs into issue, it is suppressed. See
https://github.com/chanzuckerberg/sorbet-rails/blob/master/lib/sorbet-rails/model_rbi_formatter.rb#L128

We should provide a way to run with allow_failure: false for debugging.

Expected behavior:

Introduce a debug mode, eg:

RAILS_RBI_DEBUG=true rake rails_rbi:models...

that would trigger a run with allow_failure false.

Versions:

  • Ruby:
  • Rails:
  • Sorbet:
  • Sorbet-Rails:
@hdoan741 hdoan741 added bug Something isn't working good first issue Good for newcomers labels Aug 17, 2020
@coreyja
Copy link

coreyja commented Jan 20, 2021

This issues seems to be closed by #393!

The ENV VAR is SBR_DEBUG_MODE and you need version >= 0.7.3 to use it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants