-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat split component remote states #798
Closed
vincenthsh
wants to merge
61
commits into
chanzuckerberg:main
from
vincenthsh:feat-split-component-remote-states
Closed
feat split component remote states #798
vincenthsh
wants to merge
61
commits into
chanzuckerberg:main
from
vincenthsh:feat-split-component-remote-states
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vincenthsh
commented
Feb 23, 2023
- chore: Bump go from 1.17 to 1.18
- chore: build CI use go-version-file
- feat: Add support for multiple modules per component
- chore: Disable integration test
- Add senstive field from module to module invocation outputs tpl
- Add ability to disable Global at env config level
- deprecate template provider
- chore: Update random provider to latest
- Update golden test files
- feat: Add Sops provider
- Re-enable TestIntegration and update-golden-files
- chore: Add release please workflow
- chore: bump github.com/fatih/color from 1.10.0 to 1.13.0 (Ryanking/vendor #5)
- chore: bump github.com/go-errors/errors from 1.1.1 to 1.4.2 (vendor dependencies with dep #4)
- chore: update fork (remove pointers to slices #7)
- feat: Add support for atlantis repoCfg (move close out of config.ReadConfig #8)
- chore: bump github.com/aws/aws-sdk-go from 1.44.105 to 1.44.120 (add CODEOWNERS #3)
- fix: Use github token
- chore: bump github.com/spf13/cobra from 1.5.0 to 1.6.0 (PR 1 for fogg #1)
- chore(feat-multi-module-components): release 0.75.0 (refactor apply to write tests #6)
- chore: bump github.com/aws/aws-sdk-go from 1.44.120 to 1.44.121 (user errors.Wrap to give context to errors #9)
- chore: bump github.com/stretchr/testify from 1.8.0 to 1.8.1 (change from OtherAccounts to AllAccounts #10)
- chore: bump github.com/spf13/cobra from 1.6.0 to 1.6.1 (fix apply #12)
- chore: bump github.com/aws/aws-sdk-go from 1.44.121 to 1.44.122 (apply modules #13)
- feat: Add pre-commit to Github Actions workflow (fmt .tf files when applying #14)
- chore(feat-multi-module-components): release 0.76.0 (add global component #11)
- fix: Read terraformVersion from ComponentCommon.Common (add a sicc compatibility mode #15)
- chore(feat-multi-module-components): release 0.76.1 (cloud-env via parsing module #16)
- chore: bump github.com/aws/aws-sdk-go from 1.44.122 to 1.44.126 (sort module variables and outputs #17)
- chore: bump github.com/aws/aws-sdk-go from 1.44.126 to 1.44.131 (support split regions for providers and backends #19)
- fix: fogg ci gh actions tflint (add remote state for global in components #23)
- chore: bump github.com/aws/aws-sdk-go from 1.44.131 to 1.44.136 (push the bootstrap module thing to plan #21)
- chore: bump github.com/hashicorp/hcl/v2 from 2.14.1 to 2.15.0 (fix formatting of lint & fmt in makefiles #22)
- chore(feat-multi-module-components): release 0.76.2 (Use chanzuckerberg/terraform docker image #18)
- fix: fogg ci gh actions tflint (check that we are at the root of a git repo #25)
- chore: bump github.com/aws/aws-sdk-go from 1.44.136 to 1.44.139 (fix account id inheritance #24)
- fix: fogg ci gh actions typo on tflint cache (config validations #27)
- chore(feat-multi-module-components): release 0.76.3 (speed up module bootstrapping … #26)
- fix: change fogg ci gh actions to run on pr (errors.Wrap pass #28)
- chore(feat-multi-module-components): release 0.76.4 (better help #29)
- fix: Small makefile fixes for visibility (switch to logrus #30)
- chore(feat-multi-module-components): release 0.76.5 (re-enable smoke-test now that modules are fast #31)
- fix: Add tflint ignores (better config validation errors #32)
- chore(feat-multi-module-components): release 0.76.6 (debug and quiet flags #33)
- fix: switching fogg gh ci to pull_request broke commits (fmt output.tf in bootstrapped module #34)
- fix fogg ci pr (docs #36)
- chore(feat-multi-module-components): release 0.76.7 (release tools #35)
- fix: fogg gh ci invalid yaml (write .fogg-version file #37)
- chore(feat-multi-module-components): release 0.76.8 (Ignore errors when trying to remove .sicc-version #38)
- fix: prevent changes to .terraform-version (Scripts aren't made executable by fogg #39)
- chore(feat-multi-module-components): release 0.76.9 (Automatically create the s3 bucket for state #40)
- chore: bump github.com/aws/aws-sdk-go from 1.44.139 to 1.44.204 (fix executable scripts #65)
- chore: bump github.com/hashicorp/hcl/v2 from 2.15.0 to 2.16.1 (log full paths on apply #63)
- chore: bump github.com/aws/aws-sdk-go from 1.44.204 to 1.44.207 (fix various issues brought up by linters #67)
- chore: bump github.com/hashicorp/go-getter from 1.6.2 to 1.7.0 (fix path to global state file #62)
- chore: bump github.com/fatih/color from 1.13.0 to 1.14.1 (prep release 0.10.1 #55)
- chore: bump golang.org/x/net from 0.1.0 to 0.7.0 (move makefiles to 1 place and link #68)
- chore: bump github.com/runatlantis/atlantis from 0.20.1 to 0.22.3 (debug logging for opening git index #56)
- feat: Split component remote-state files for exclusion in Atlantis autoplan
BREAKING CHANGE chore: Rebase
TODO: Need to revert this
Bumps [github.com/fatih/color](https://github.com/fatih/color) from 1.10.0 to 1.13.0. - [Release notes](https://github.com/fatih/color/releases) - [Commits](fatih/color@v1.10.0...v1.13.0) --- updated-dependencies: - dependency-name: github.com/fatih/color dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/go-errors/errors](https://github.com/go-errors/errors) from 1.1.1 to 1.4.2. - [Release notes](https://github.com/go-errors/errors/releases) - [Commits](go-errors/errors@v1.1.1...v1.4.2) --- updated-dependencies: - dependency-name: github.com/go-errors/errors dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: Bump GitHub action versions * chore: Update setup scripts
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.105 to 1.44.120. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.105...v1.44.120) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.120 to 1.44.121. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.120...v1.44.121) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.0...v1.8.1) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.0 to 1.6.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.6.0...v1.6.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.121 to 1.44.122. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.121...v1.44.122) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fogg apply causes problems with pre-commit, adding pre-commit to the fogg generated GitHub Action workflow prevents these problems. Ideally the pre-commit configuration ignores the fogg changes or the fogg templates are updated to match the pre-commit expectations.
This seems to fix the incorrect terraform version being detected per component
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.136 to 1.44.139. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.136...v1.44.139) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fix typo in cache name for tflint plugins
tflint problem matcher is bundled in dist and doesn't need to be added to repo. annotations aren't showing up on PR, also fogg apply should only run on PR, so changing workflow trigger to `pull_request`
- Force tflint to use config at repo root - Add echo for clarity on which directory is being linted
- Reduce tflint errors by adding ingores in fogg generated files - update golden test files
* fix: switching fogg gh ci to pull_request broke commits Ref: https://github.com/EndBug/add-and-commit#working-with-prs * fix: Fix fogg ci pr fix Ensure github workflow interpolation doesn't break gotemplates
Fix missing `with` lines
* fix: prevent changes to .terraform-version Due to some strange behaviour, tfenv seems to change the contents of .terraform-version at repo root * chore: run make update-golden-files
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.139 to 1.44.204. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.139...v1.44.204) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.15.0 to 2.16.1. - [Release notes](https://github.com/hashicorp/hcl/releases) - [Changelog](https://github.com/hashicorp/hcl/blob/main/CHANGELOG.md) - [Commits](hashicorp/hcl@v2.15.0...v2.16.1) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcl/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.204 to 1.44.207. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.204...v1.44.207) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.6.2 to 1.7.0. - [Release notes](https://github.com/hashicorp/go-getter/releases) - [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml) - [Commits](hashicorp/go-getter@v1.6.2...v1.7.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-getter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/fatih/color](https://github.com/fatih/color) from 1.13.0 to 1.14.1. - [Release notes](https://github.com/fatih/color/releases) - [Commits](fatih/color@v1.13.0...v1.14.1) --- updated-dependencies: - dependency-name: github.com/fatih/color dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.1.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.1.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: bump github.com/runatlantis/atlantis from 0.20.1 to 0.22.3 Bumps [github.com/runatlantis/atlantis](https://github.com/runatlantis/atlantis) from 0.20.1 to 0.22.3. - [Release notes](https://github.com/runatlantis/atlantis/releases) - [Changelog](https://github.com/runatlantis/atlantis/blob/main/CHANGELOG.md) - [Commits](runatlantis/atlantis@v0.20.1...v0.22.3) --- updated-dependencies: - dependency-name: github.com/runatlantis/atlantis dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore: Atlantis library changes - Fix enum field changes - Adopt chanzuckerberg#776 go mod updates --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vincent De Smet <[email protected]>
…toplan To avoid Atlantis re-planning every component each time a component is added into an environment, we split the remote-states into a separate file and ignore it from auto_plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.