Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add pre-commit to Github Actions workflow #14

Merged
merged 1 commit into from
Oct 31, 2022
Merged

feat: Add pre-commit to Github Actions workflow #14

merged 1 commit into from
Oct 31, 2022

Conversation

vincenthsh
Copy link
Owner

@vincenthsh vincenthsh commented Oct 31, 2022 •
edited
Loading

fogg apply causes problems with pre-commit, adding pre-commit to the fogg generated GitHub Action workflow prevents these problems.

Ideally the pre-commit configuration ignores the fogg changes or the fogg templates are updated to match the pre-commit expectations.

Note: This commit also cleans up golang 1.18 deprecated libraries and tries to re-use functions to get ptr for literals from util package

@vincenthsh
feat: Add pre-commit to Github Actions workflow
2583dc5 
fogg apply causes problems with pre-commit, adding pre-commit to the
fogg generated GitHub Action workflow prevents these problems.

Ideally the pre-commit configuration ignores the fogg changes or
the fogg templates are updated to match the pre-commit expectations.
@vincenthsh vincenthsh merged commit dddef4c into feat-multi-module-components Oct 31, 2022
@vincenthsh vincenthsh deleted the feat-gha-fogg-ci-pre-commit branch October 31, 2022 03:30
@vincenthsh vincenthsh mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vincenthsh