Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the font-family format supported by Google Web Font #2209

Merged

Conversation

leejiwoo2002
Copy link
Contributor

@leejiwoo2002 leejiwoo2002 commented May 9, 2024

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Summary

Add the font-family format supported by Google Web Font
(ex. NotoSansKR -> Noto Sans KR)

Considering the existing uses, we only add the contents without modifying them

스크린샷 2024-05-09 오후 5 34 50

Breaking change? (Yes/No)

No

References

@leejiwoo2002 leejiwoo2002 added enhancement Issues or PR related to making existing features better bezier-tokens Issue or PR related to bezier-tokens labels May 9, 2024
@leejiwoo2002 leejiwoo2002 self-assigned this May 9, 2024
Copy link

channeltalk bot commented May 9, 2024

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: d1d1723

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@channel.io/bezier-tokens Patch
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.61%. Comparing base (ffecfdf) to head (d1d1723).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2209   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files         132      132           
  Lines        2843     2843           
  Branches      850      854    +4     
=======================================
  Hits         2434     2434           
  Misses        380      380           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leejiwoo2002 leejiwoo2002 merged commit 79072d9 into channel-io:main May 10, 2024
5 checks passed
@leejiwoo2002 leejiwoo2002 deleted the feat/add-google-font-naming branch May 10, 2024 06:29
sungik-choi pushed a commit that referenced this pull request May 10, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Minor Changes

- Update icons
([#2204](#2204)) by
@kimminkyung94

    Added

    -   center-focus.svg
    -   group-remove-filled.svg
    -   shipping-filled.svg
    -   snooze-filled.svg
    -   star-circle-filled.svg
    -   untag-filled.svg
    -   workflow.svg

    Modified

    -   chat-check-filled.svg
    -   chat-check.svg
    -   chat-progress-filled.svg
    -   chat-progress.svg
    -   check-circle-filled.svg
    -   check-circle.svg
    -   check-verification-filled.svg
    -   clock-filled.svg
    -   contract.svg
    -   expand.svg
    -   goal.svg
    -   limit.svg
    -   people.svg
    -   tag.svg
    -   untag.svg

## @channel.io/[email protected]

### Patch Changes

- Change outline color of primary and blue `Button` component when
focused. ([#2182](#2182))
by @yangwooseong

- Add `AlphaButton` component.
([#2182](#2182)) by
@yangwooseong

- Add `AlphaFloatingButton` component.
([#2193](#2193)) by
@yangwooseong

-   Updated dependencies
    -   @channel.io/[email protected]

## @channel.io/[email protected]

### Patch Changes

- Add the font-family format supported by Google Web Font
([#2209](#2209)) by
@leejiwoo2002

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bezier-tokens Issue or PR related to bezier-tokens enhancement Issues or PR related to making existing features better
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants