-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AlphaFloatingButton
component
#2193
Add AlphaFloatingButton
component
#2193
Conversation
🦋 Changeset detectedLatest commit: 10f62d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2193 +/- ##
==========================================
- Coverage 86.22% 85.61% -0.61%
==========================================
Files 131 132 +1
Lines 2823 2843 +20
Branches 843 841 -2
==========================================
Hits 2434 2434
- Misses 384 404 +20
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Chromatic Report🚀 Congratulations! Your build was successful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Button
과 중복되는 부분이 꽤 있지만, 이건 전체 버튼 컴포넌트 군을 다 만들어보고 리팩토링해서 개선해보면 될 거 같아요
fed2ebe
to
10f62d7
Compare
<!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> <!-- Fixes #0000 --> - None ## Summary <!-- Please brief explanation of the changes made --> - checkout action 에서 있었던 오타를 수정합니다. ## Details <!-- Please elaborate description of the changes --> - https://github.com/channel-io/bezier-react/actions?query=workflow%3ARelease++ 을 보면 changeset pr이 올라가야 하는데 Release 가 돌지 않아서 올라가지 않은 pr (#2193) 이 하나 있습니다. 이거는 추후에 changeset pr 이 생성되면 디스크립션을 수정해서 pr 을 넣어야할 것 같네요.. ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> - None ## References <!-- Please list any other resources or points the reviewer should be aware of --> - https://github.com/actions/checkout?tab=readme-ov-file#usage
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Minor Changes - Update icons ([#2204](#2204)) by @kimminkyung94 Added - center-focus.svg - group-remove-filled.svg - shipping-filled.svg - snooze-filled.svg - star-circle-filled.svg - untag-filled.svg - workflow.svg Modified - chat-check-filled.svg - chat-check.svg - chat-progress-filled.svg - chat-progress.svg - check-circle-filled.svg - check-circle.svg - check-verification-filled.svg - clock-filled.svg - contract.svg - expand.svg - goal.svg - limit.svg - people.svg - tag.svg - untag.svg ## @channel.io/[email protected] ### Patch Changes - Change outline color of primary and blue `Button` component when focused. ([#2182](#2182)) by @yangwooseong - Add `AlphaButton` component. ([#2182](#2182)) by @yangwooseong - Add `AlphaFloatingButton` component. ([#2193](#2193)) by @yangwooseong - Updated dependencies - @channel.io/[email protected] ## @channel.io/[email protected] ### Patch Changes - Add the font-family format supported by Google Web Font ([#2209](#2209)) by @leejiwoo2002 ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Self Checklist
Related Issue
Summary
AlphaFloatingButton
컴포넌트를 구현합니다.AlphaButton
컴포넌트와 일부 스타일을 제외하고 거의 동일합니다.Details
Breaking change? (Yes/No)
References