Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlphaFloatingButton component #2193

Merged

Conversation

yangwooseong
Copy link
Collaborator

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • AlphaFloatingButton 컴포넌트를 구현합니다. AlphaButton컴포넌트와 일부 스타일을 제외하고 거의 동일합니다.

Details

  • 생략

Breaking change? (Yes/No)

  • No

References

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 10f62d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yangwooseong yangwooseong self-assigned this May 2, 2024
@yangwooseong yangwooseong added the feat:component Issue or PR related to a new component label May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 85.61%. Comparing base (0b2f48f) to head (10f62d7).

Files Patch % Lines
.../components/AlphaFloatingButton/FloatingButton.tsx 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2193      +/-   ##
==========================================
- Coverage   86.22%   85.61%   -0.61%     
==========================================
  Files         131      132       +1     
  Lines        2823     2843      +20     
  Branches      843      841       -2     
==========================================
  Hits         2434     2434              
- Misses        384      404      +20     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 2, 2024

Chromatic Report

🚀 Congratulations! Your build was successful!

@channel-io channel-io deleted a comment from channeltalk bot May 7, 2024
Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Button 과 중복되는 부분이 꽤 있지만, 이건 전체 버튼 컴포넌트 군을 다 만들어보고 리팩토링해서 개선해보면 될 거 같아요

Copy link

channeltalk bot commented May 7, 2024

@yangwooseong yangwooseong merged commit 0d6d0e4 into channel-io:main May 7, 2024
7 of 9 checks passed
@yangwooseong yangwooseong deleted the WEB-598/add-floating-button branch May 7, 2024 07:34
yangwooseong added a commit that referenced this pull request May 9, 2024
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->

- None

## Summary

<!-- Please brief explanation of the changes made -->

- checkout action 에서 있었던 오타를 수정합니다.

## Details

<!-- Please elaborate description of the changes -->

-
https://github.com/channel-io/bezier-react/actions?query=workflow%3ARelease++
을 보면 changeset pr이 올라가야 하는데 Release 가 돌지 않아서 올라가지 않은 pr (#2193) 이 하나
있습니다. 이거는 추후에 changeset pr 이 생성되면 디스크립션을 수정해서 pr 을 넣어야할 것 같네요..

### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

- None

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->

- https://github.com/actions/checkout?tab=readme-ov-file#usage
sungik-choi pushed a commit that referenced this pull request May 10, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Minor Changes

- Update icons
([#2204](#2204)) by
@kimminkyung94

    Added

    -   center-focus.svg
    -   group-remove-filled.svg
    -   shipping-filled.svg
    -   snooze-filled.svg
    -   star-circle-filled.svg
    -   untag-filled.svg
    -   workflow.svg

    Modified

    -   chat-check-filled.svg
    -   chat-check.svg
    -   chat-progress-filled.svg
    -   chat-progress.svg
    -   check-circle-filled.svg
    -   check-circle.svg
    -   check-verification-filled.svg
    -   clock-filled.svg
    -   contract.svg
    -   expand.svg
    -   goal.svg
    -   limit.svg
    -   people.svg
    -   tag.svg
    -   untag.svg

## @channel.io/[email protected]

### Patch Changes

- Change outline color of primary and blue `Button` component when
focused. ([#2182](#2182))
by @yangwooseong

- Add `AlphaButton` component.
([#2182](#2182)) by
@yangwooseong

- Add `AlphaFloatingButton` component.
([#2193](#2193)) by
@yangwooseong

-   Updated dependencies
    -   @channel.io/[email protected]

## @channel.io/[email protected]

### Patch Changes

- Add the font-family format supported by Google Web Font
([#2209](#2209)) by
@leejiwoo2002

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat:component Issue or PR related to a new component
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Floating Button
2 participants