Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate xpallets-assets to attribute macro #560

Merged
merged 8 commits into from
Jun 16, 2021
Merged

Conversation

0xrjman
Copy link

@0xrjman 0xrjman commented Jun 15, 2021

Migrate XAssets Record

Migrate Guide

  1. Subtrate issue#7882
  2. Chainx issue#552
  3. Upgrade-guidelines

Migrate Description

migrate xpallet-assets module to pallet(attribute macro)

Check Upgrade Status -> Pass

  1. Check the format of pallet(template required)
    pallet-format
  2. Use subsee to do a diff of metadata(origin, after migration)
    • add 1 comment
      • add-1
      • add-2
    • amend 3 comments
      • amend-1
      • amend-2

@0xrjman 0xrjman changed the title Migrate xpallets-assets to pallet v2 Migrate xpallets-assets to pallet v2 Jun 15, 2021
@0xrjman 0xrjman requested a review from liuchengxu June 15, 2021 10:09
@liuchengxu liuchengxu requested a review from hacpy June 15, 2021 10:18
@0xrjman 0xrjman force-pushed the xassets-migration branch from ebf5857 to 3addce0 Compare June 15, 2021 10:57
@0xrjman 0xrjman force-pushed the xassets-migration branch from 3addce0 to 32bd016 Compare June 15, 2021 10:58
xpallets/assets/src/lib.rs Outdated Show resolved Hide resolved
xpallets/assets/src/lib.rs Outdated Show resolved Hide resolved
xpallets/assets/src/lib.rs Outdated Show resolved Hide resolved
@liuchengxu liuchengxu merged commit 7b60cc8 into develop Jun 16, 2021
@liuchengxu liuchengxu deleted the xassets-migration branch June 16, 2021 07:25
@0xrjman 0xrjman changed the title Migrate xpallets-assets to pallet v2 Migrate xpallets-assets to attribute macro Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants