Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate xpallet-dex-spot to attribute macro #559

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Migrate xpallet-dex-spot to attribute macro #559

merged 3 commits into from
Jun 16, 2021

Conversation

hacpy
Copy link
Member

@hacpy hacpy commented Jun 15, 2021

Part of #522

@liuchengxu liuchengxu requested a review from 0xrjman June 15, 2021 10:18
0xrjman
0xrjman approved these changes Jun 16, 2021
View reviewed changes
Copy link

@0xrjman 0xrjman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuchengxu liuchengxu merged commit 5495ef1 into develop Jun 16, 2021
@liuchengxu liuchengxu deleted the dex-spot-migration branch June 16, 2021 05:21
@0xrjman 0xrjman mentioned this pull request Jun 16, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuchengxu liuchengxu liuchengxu left review comments

@0xrjman 0xrjman 0xrjman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacpy @liuchengxu @0xrjman