Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate xpallet-asset-registrar to pallet v2 #550

Merged
merged 25 commits into from
Jun 12, 2021
Merged

Migrate xpallet-asset-registrar to pallet v2 #550

merged 25 commits into from
Jun 12, 2021

Conversation

VegeBun-csj
Copy link

image

@VegeBun-csj
Copy link
Author

pass all the tests

image

liuchengxu
liuchengxu suggested changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@liuchengxu liuchengxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge the latest develop branch and then make the ci pass.

@liuchengxu liuchengxu mentioned this pull request Jun 10, 2021
Closed
21 tasks
VegeBun-csj added 18 commits June 10, 2021 17:36
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
743be74
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
ec7ee76
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
dc31c81
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
7068936
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
606fbdd
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
033f5cb
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
dd47b6f
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
d60d75a
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
f0fe96c
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
d5b45f1
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
4e83d04
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
c846024
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
18b0e5b
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
6ce29c1
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
c95c6a8
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
9a89c5f
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
c1103f7
@VegeBun-csj
migrate xpallets-assets-registrar pallet v2
96b562f
@liuchengxu liuchengxu requested review from alannotnerd and hacpy June 12, 2021 03:12
hacpy
hacpy reviewed Jun 12, 2021
View reviewed changes
Copy link
Member

@hacpy hacpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to rearrange the order of pallet components in the following order:

  • pallet::config
  • pallet::pallet
  • pallet::call
  • pallet::event
  • pallet::error
  • pallet::storage

@liuchengxu liuchengxu requested review from AAweidai and 0xrjman June 12, 2021 07:59
@VegeBun-csj VegeBun-csj merged commit bbbf492 into chainx-org:develop Jun 12, 2021
VegeBun-csj added a commit that referenced this pull request Jun 12, 2021
@VegeBun-csj
Revert "Migrate xpallet-asset-registrar to pallet v2 (#550)"
a20a68a 
This reverts commit bbbf492.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacpy hacpy hacpy left review comments

@liuchengxu liuchengxu liuchengxu requested changes

@alannotnerd alannotnerd Awaiting requested review from alannotnerd

@AAweidai AAweidai Awaiting requested review from AAweidai

@0xrjman 0xrjman Awaiting requested review from 0xrjman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VegeBun-csj @liuchengxu @hacpy