Remove OmitEmpty; fix nil pointer dereference #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <[email protected]>
|
Looking into this again: |
Signed-off-by: egibs <[email protected]>
tstromberg
approved these changes
Jul 10, 2024
egibs
commented
Jul 10, 2024
| if len(fr.Behaviors) == 0 && c.OmitEmpty { | ||
| return nil, nil | ||
| if len(fr.Behaviors) == 0 { | ||
| return &bincapz.FileReport{Path: path}, nil |
There was a problem hiding this comment.
Without this, rel, err := filepath.Rel(fromPath, f.Path) results in ..
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Aug 5, 2024
* Remove OmitEmpty; fix nil pointer dereference Signed-off-by: egibs <[email protected]> * Prevent . being reported for rel path Signed-off-by: egibs <[email protected]> --------- Signed-off-by: egibs <[email protected]>
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
* Remove OmitEmpty; fix nil pointer dereference Signed-off-by: egibs <[email protected]> * Prevent . being reported for rel path Signed-off-by: egibs <[email protected]> --------- Signed-off-by: egibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #348
This PR removes the [unused]
--omit-emptyflag.Additionally, since we're now returning
nilwhen onlylen(fr.Behaviors)is0, the ordering ofif fr.Error != "" { ... }beforeif fr == nil { ... }was causing a nil pointer dereference so I fixed that as well.