Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused --omit-empty flag #348

Closed
tstromberg opened this issue Jul 10, 2024 · 1 comment · Fixed by #351
Closed

Remove unused --omit-empty flag #348

tstromberg opened this issue Jul 10, 2024 · 1 comment · Fixed by #351
Assignees
@egibs

Comments

@tstromberg
Copy link
Collaborator

tstromberg commented Jul 10, 2024 •
edited
Loading

I believe this flag is broken, and nobody uses it.

I think the intended behavior (files with no results are omitted from the output) is already happening elsewhere.

Related to #347
This was referenced Jul 10, 2024
Closed
Merged
@egibs egibs self-assigned this Jul 10, 2024
@egibs
Copy link
Member

egibs commented Jul 10, 2024 •
edited
Loading

I agree -- we should just passively omit empty files instead of having a separate flag to control the behavior.

@egibs egibs mentioned this issue Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egibs egibs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove OmitEmpty; fix nil pointer dereference egibs/malcontent
2 participants
@tstromberg @egibs