Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -rc and deprecated tests (#107) #108

Merged
merged 1 commit into from
Dec 20, 2024
Merged

remove -rc and deprecated tests (#107) #108

merged 1 commit into from
Dec 20, 2024

Conversation

VjeraTurk
Copy link

@VjeraTurk VjeraTurk commented Dec 20, 2024

  • remove -rc

  • remove deprecated tests

Summary by CodeRabbit

  • New Features
    • Transitioned the project version from a release candidate to a stable release.

* remove -rc

* remove deprecated tests
@VjeraTurk VjeraTurk requested a review from mo-c4t December 20, 2024 11:37
Copy link

coderabbitai bot commented Dec 20, 2024

📝 Walkthrough

Walkthrough

This pull request involves two main changes: updating the package.json version from 1.3.0-rc1 to 1.3.0, signifying a transition to a stable release, and modifications to the PlatformVMAPI test suite in api.test.ts. The test file updates include adding a commented-out block for a new validator transaction method and updating existing test cases with more detailed parameters for transaction building.

Changes

File Change Summary
package.json Version updated from 1.3.0-rc1 to 1.3.0
tests/apis/platformvm/api.test.ts - Updated test cases for buildAddValidatorTx with new parameters
- Added commented-out block for buildAddCaminoValidatorTx method
- Enhanced test specificity for transaction serialization

Possibly related PRs

Suggested reviewers

  • aeddaqqa
  • mo-c4t

Poem

🐰 A version hop, from RC to gold,
Tests polished, stories untold,
Camino's path now clear and bright,
Code dancing with technical might,
Release complete, our rabbit's delight! 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
tests/apis/platformvm/api.test.ts (3)

Line range hint 1613-1686: Consider converting this test to the new API if it remains valid.
The “buildAddValidatorTx sort StakeableLockOuts 1” test ensures correct handling of stakeable lock times. If it still applies, rewrite it to the updated method. Otherwise, remove it if the new function will differ enough that these checks are no longer applicable.


Line range hint 1687-1791: Ensure partial UTXO consumption logic is still required.
The “buildAddValidatorTx sort StakeableLockOuts 2” test checks partial consumption of multiple stakeable lock outputs. If you still need partial UTXO logic in the new method, adapt these assertions accordingly.


Line range hint 1792-2149: Update or remove multi-UTXO stake locktime tests.
The “buildAddValidatorTx sort StakeableLockOuts 3” test checks a combination of UTXO types. If “buildAddCaminoValidatorTx” is becoming the new approach, ensure that these multi-UTXO scenarios are properly covered under the new method or remove the test if no longer relevant.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5561502 and b9ce279.

📒 Files selected for processing (2)
  • package.json (1 hunks)
  • tests/apis/platformvm/api.test.ts (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • package.json

tests/apis/platformvm/api.test.ts Show resolved Hide resolved
@VjeraTurk VjeraTurk requested a review from aeddaqqa December 20, 2024 11:51
@VjeraTurk VjeraTurk merged commit dc8f218 into c4t Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants