-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove -rc and deprecated tests (#107) #108
Conversation
* remove -rc * remove deprecated tests
📝 WalkthroughWalkthroughThis pull request involves two main changes: updating the Changes
Possibly related PRs
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
tests/apis/platformvm/api.test.ts (3)
Line range hint
1613-1686
: Consider converting this test to the new API if it remains valid.
The “buildAddValidatorTx sort StakeableLockOuts 1” test ensures correct handling of stakeable lock times. If it still applies, rewrite it to the updated method. Otherwise, remove it if the new function will differ enough that these checks are no longer applicable.
Line range hint
1687-1791
: Ensure partial UTXO consumption logic is still required.
The “buildAddValidatorTx sort StakeableLockOuts 2” test checks partial consumption of multiple stakeable lock outputs. If you still need partial UTXO logic in the new method, adapt these assertions accordingly.
Line range hint
1792-2149
: Update or remove multi-UTXO stake locktime tests.
The “buildAddValidatorTx sort StakeableLockOuts 3” test checks a combination of UTXO types. If “buildAddCaminoValidatorTx” is becoming the new approach, ensure that these multi-UTXO scenarios are properly covered under the new method or remove the test if no longer relevant.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
package.json
(1 hunks)tests/apis/platformvm/api.test.ts
(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- package.json
remove -rc
remove deprecated tests
Summary by CodeRabbit