-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove -rc and deprecated tests #107
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request includes a version update for the Changes
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/apis/platformvm/api.test.ts (1)
Line range hint
1611-2149
: Reactivate or remove commented-out tests.A sizeable commented-out portion of the code references a desire to rename tests from “buildAddValidatorTx” to “buildAddCaminoValidatorTx.” If you do plan to keep these tests, consider re-enabling them under the corrected method name or adapting them to your new approach. Otherwise, removing them could simplify the code and avoid confusion.
Would you like help refactoring or rewriting these tests?
If I remember correctly, there was a suggestion for the next release to not be -rc
Removed the deprecated tests
Summary by CodeRabbit
New Features
parameters for existing methods.
Bug Fixes