Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -rc and deprecated tests #107

Merged
merged 2 commits into from
Dec 20, 2024
Merged

remove -rc and deprecated tests #107

merged 2 commits into from
Dec 20, 2024

Conversation

VjeraTurk
Copy link

@VjeraTurk VjeraTurk commented Dec 19, 2024

If I remember correctly, there was a suggestion for the next release to not be -rc
Removed the deprecated tests

Summary by CodeRabbit

  • New Features

    • Updated the project version from a release candidate to a stable version (1.3.0).
      parameters for existing methods.
  • Bug Fixes

    • No bug fixes were included in this release.

@VjeraTurk VjeraTurk requested a review from mo-c4t December 19, 2024 12:25
Copy link

coderabbitai bot commented Dec 19, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request includes a version update for the @c4tplatform/caminojs project, moving from a release candidate (1.3.0-rc1) to a stable version (1.3.0). Additionally, significant modifications have been made to the test suite for the PlatformVMAPI class, including updates to method signatures and the introduction of new tests for various transaction types. Some existing tests have been commented out, indicating a shift in the testing strategy.

Changes

File Change Summary
package.json Version updated from 1.3.0-rc1 to 1.3.0
tests/apis/platformvm/api.test.ts Updated tests for buildAddValidatorTx, buildAddDelegatorTx, buildCreateSubnetTx, and buildClaimTx with new parameters; some tests commented out; new tests added for additional transaction types.

Poem

🐰 A version hop, from RC to gold,
Code polished bright, a story untold.
One point three point zero, now complete,
Rabbit's release dance, oh so sweet!
Stable and ready, let's celebrate! 🎉

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@VjeraTurk VjeraTurk changed the base branch from dev to c4t December 19, 2024 12:31
Copy link

⚠️ Found errors/fatal log records. Please review them(job:e2e, step:"Check produced logs") and resolve this comment.

2 errors
0 fatal

@VjeraTurk VjeraTurk changed the base branch from c4t to dev December 19, 2024 12:46
@mo-c4t mo-c4t closed this Dec 19, 2024
@mo-c4t mo-c4t reopened this Dec 19, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
tests/apis/platformvm/api.test.ts (1)

Line range hint 1611-2149: Reactivate or remove commented-out tests.

A sizeable commented-out portion of the code references a desire to rename tests from “buildAddValidatorTx” to “buildAddCaminoValidatorTx.” If you do plan to keep these tests, consider re-enabling them under the corrected method name or adapting them to your new approach. Otherwise, removing them could simplify the code and avoid confusion.

Would you like help refactoring or rewriting these tests?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f3cb56 and 731e6b1.

📒 Files selected for processing (1)
  • tests/apis/platformvm/api.test.ts (2 hunks)

@VjeraTurk VjeraTurk requested a review from aeddaqqa December 20, 2024 11:21
@VjeraTurk VjeraTurk changed the title remove -rc remove -rc and deprecated tests Dec 20, 2024
@VjeraTurk VjeraTurk merged commit b9ce279 into dev Dec 20, 2024
7 checks passed
@VjeraTurk VjeraTurk deleted the VjeraTurk/non-rc-version branch December 20, 2024 11:37
VjeraTurk added a commit that referenced this pull request Dec 20, 2024
* remove -rc

* remove deprecated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants