Added naming convention check #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1968. This PR adds the actual naming convention check as well as a mode for automatically fixing improperly named functions and files.
The naming convention check + fix itself is rather simple. It's just a small function. The interesting bit is the stuff around it.
I generalized the
TYPE_CHECK_LEVELlogic to (1) include aFIXcheck level, and (2) added aNAME_CHECK_LEVEL. So name check is controlled via env vars just like the type check. There is now also aCHECK_LEVELenv var to control both at once.CHECK_LEVELwill be very useful if we add more checks in the future.I also changed the check level from
WARNtoFIXfornpm run dev. This has the interesting effect that the server will automatically rename functions and files when you change the name of a node.