Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce naming conventions #1968

Merged

Conversation

RunDevelopment
Copy link
Member

This PR enforces the following naming conventions:

  1. The file name of a node is the node name.
  2. The function name of a node is the node name + _node.
  3. The function name of a helper node is iterator_helper_ + node name + _node.

I have chosen those naming conventions (especially for iterator helpers), because they can be automatically fixed. In fact, I did not enforce them by hand. I added some code to register that automatically enforces them by changing the source files themselves. However, I still need to think of a good API for this, so it will be added in a later PR.

joeyballentine
joeyballentine previously approved these changes Jul 22, 2023
@joeyballentine joeyballentine merged commit c3f5edb into chaiNNer-org:main Jul 22, 2023
10 checks passed
@RunDevelopment RunDevelopment deleted the enforce-naming-conventions branch July 22, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants