42 add get submission endpoint #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcadam14
requested review from
lchen-2101,
hkeeler,
guffee23 and
nargis-sultani
Was in my poetry.lock so running pytests was good locally
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
lchen-2101
reviewed
Feb 2, 2024
tests/api/routers/test_filing_api.py
Outdated
| validation_ruleset_version="v1", | ||
| ) | ||
| ] | ||
| return mock |
There was a problem hiding this comment.
why a return here? the actual test code isn't being reached, right?
There was a problem hiding this comment.
Correct, that was a copy/paste error. Originally I had it as a fixture but then moved the get_submissions mock to inside the actual test function (is there a preference for one over the other?). Removed that and revealed the second assert_called_once failed so switched those to just assert_called_with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42
Part of this pulled in changes from #41 for the api conftest and the set_db function for Routers
Also fixed the test_get_filing function which was actually testing filing periods, not filings.