Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

40 create filing period get route #41

Merged
merged 3 commits into from
Jan 31, 2024
Merged

40 create filing period get route #41

merged 3 commits into from
Jan 31, 2024

Conversation

jcadam14
Copy link
Contributor

Closes #40

  • Added /periods route to filing.py, along with the supporting get_session function for db connections
  • Added get_filing_periods function to submission_repo to return all FilingPeriod objects in the db
  • Added pytests for the route and the new submission_repo function

@jcadam14 jcadam14 linked an issue Jan 24, 2024 that may be closed by this pull request
Create filing period GET route #40
Closed
@jcadam14 jcadam14 self-assigned this Jan 24, 2024
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src
  main.py
  src/entities/repos
  submission_repo.py
  src/routers
  __init__.py
  filing.py
  src/services
  submission_processor.py
Project Total  

This report was generated by python-coverage-comment-action

@jcadam14 jcadam14 mentioned this pull request Jan 29, 2024
Merged
lchen-2101
lchen-2101 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit 906df07 into main Jan 31, 2024
3 checks passed
@lchen-2101 lchen-2101 deleted the 40-create-filing-period-get-route branch January 31, 2024 17:16
lchen-2101 pushed a commit that referenced this pull request Feb 2, 2024
@jcadam14
42 add get submission endpoint (#44)
644a803 
Closes #42 

Part of this pulled in changes from
#41 for the api conftest and
the set_db function for Routers

Also fixed the test_get_filing function which was actually testing
filing periods, not filings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchen-2101 lchen-2101 lchen-2101 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@guffee23 guffee23 Awaiting requested review from guffee23

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees

@jcadam14 jcadam14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create filing period GET route
2 participants
@jcadam14 @lchen-2101