In tree, add "end" and "after-end" as values for parent-position #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I've added tests in PR #445. |
johannes-wolf
added a commit
that referenced
this pull request
Jan 10, 2024
Adds the missing tests for #444.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue I created last week (#429) and adds another layout choice where the parent is offset relative to the children.
Both values seem more useful for "right" and "left" direction, and actually, the "after-end" option seems more useful to me, as it allows to render a more hierarchical layout without overlapping, like this question asked on Discord: https://discord.com/channels/1054443721975922748/1193008120688037988
I did not change the existing behavior, but it was very surprising to me to see that when choosing "right" or "left" as direction, the nodes at filled from bottom to top, and it is necessary to choose "end" to have the parent on top. Is it that way for a reason? I would prefer a "before-beginning" rather than "after-end" to indicate that I want my parent above the children, it seems more intuitive to me.