Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree: "end" value for parent-position #429

Closed
leyan opened this issue Dec 30, 2023 · 1 comment
Closed

Tree: "end" value for parent-position #429

leyan opened this issue Dec 30, 2023 · 1 comment
Labels
bug 🐛 Something isn't working lib:tree

Comments

@leyan
Copy link
Contributor

leyan commented Dec 30, 2023

The documentation says that for a tree, the parent-position setting can be begin, center or end. However, only begin and center are actually implemented. It seems easy to add end, was it forgotten or removed because of a specific issue and the documentation was not updated?

@johannes-wolf johannes-wolf added bug 🐛 Something isn't working lib:tree labels Dec 30, 2023
johannes-wolf pushed a commit that referenced this issue Jan 10, 2024
This solves the issue I created last week (#429) and adds another layout
choice where the parent is offset relative to the children.

Both values seem more useful for "right" and "left" direction, and
actually, the "after-end" option seems more useful to me, as it allows
to render a more hierarchical layout without overlapping, like this
question asked on Discord:
https://discord.com/channels/1054443721975922748/1193008120688037988

I did not change the existing behavior, but it was very surprising to me
to see that when choosing "right" or "left" as direction, the nodes at
filled from bottom to top, and it is necessary to choose "end" to have
the parent on top. Is it that way for a reason? I would prefer a
"before-beginning" rather than "after-end" to indicate that I want my
parent above the children, it seems more intuitive to me.
@johannes-wolf
Copy link
Member

Fixed on 0.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working lib:tree
Projects
None yet
Development

No branches or pull requests

2 participants