Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Improvements #416

Merged
merged 58 commits into from
Jan 14, 2024
Merged

Mark Improvements #416

merged 58 commits into from
Jan 14, 2024

Conversation

johannes-wolf
Copy link
Member

@johannes-wolf johannes-wolf commented Dec 20, 2023

Rebased and improved copy of #385.

TODOs:

  • Setting flex: false is broken (see tests, wrong mark offset)
  • Add open triangle mark
  • Add curved triangle mark (barbed)
  • Add +, x and * marks
  • Allow marks being longer then their path; do not panic if a path is very short
  • Fix reversed mark offsetting
  • Fix z-axis marks
  • Add back “curve snapping” (cubic shorten curve correction)
  • Add offset
  • Add position (override a mark's position) - Allows relative or absolute mark placement on a path

@fenjalien I've pushed your branch and added some fixes, improvements and missing marks.

I've added linear path extrapolation, which is what TikZ seems to do, too. Marks can “grow” out of the path now.

@johannes-wolf johannes-wolf force-pushed the fenjalient-mark-improvements branch from 07c18b1 to 84069f9 Compare December 20, 2023 18:21
@johannes-wolf johannes-wolf mentioned this pull request Dec 20, 2023
6 tasks
@johannes-wolf johannes-wolf force-pushed the fenjalient-mark-improvements branch 2 times, most recently from ad1539f to 36734b7 Compare December 21, 2023 17:06
This was linked to issues Dec 21, 2023
@johannes-wolf johannes-wolf force-pushed the fenjalient-mark-improvements branch from 1baa842 to caaa45d Compare December 21, 2023 19:24
@johannes-wolf johannes-wolf force-pushed the fenjalient-mark-improvements branch 6 times, most recently from 79463f6 to 3f694ec Compare December 23, 2023 23:47
@johannes-wolf
Copy link
Member Author

I ported 75972d7 over.

@johannes-wolf johannes-wolf force-pushed the fenjalient-mark-improvements branch from 84d7020 to a980803 Compare January 14, 2024 13:06
@johannes-wolf johannes-wolf merged commit dd25eea into 0.2.0 Jan 14, 2024
2 checks passed
@johannes-wolf johannes-wolf deleted the fenjalient-mark-improvements branch January 14, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark Improvements List Per Mark Styling
2 participants