Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark: Some Mark Features #333

Closed
wants to merge 8 commits into from
Closed

mark: Some Mark Features #333

wants to merge 8 commits into from

Conversation

johannes-wolf
Copy link
Member

@johannes-wolf johannes-wolf commented Nov 12, 2023 •
edited
Loading

  • Added many additional arrow styles: "->", "<-", ">", "<", "]", "[", "[]", "x", "+", "*", "hook", "hook-right"
  • Added slanting for all arrows via style key slant: <angle>
  • Added thickness relative scale/length/width/inset
  • Added shorten-to that control how a path gets shortened if multiple marks are placed
  • Fixed shortening: Beziers now "snap" to the correct position to prevent gaps because of low precision arc-length calculation
  • Moved all mark drawing to mark.typ
  • Fixes grid being to wide
  • Removed harpoons: they should be reimplemented in a follow-up
  • The default mark ">" changed to another style; the old one is now "->"
  • A new reverse: <bool> style to reverse all marks
  • A new flip: <bool> style to flip all marks

Implements some parts of #331.

Some styling options:
image

The new default tip:
image

@johannes-wolf johannes-wolf added the enhancement ⬆️ New feature or request label Nov 12, 2023
@johannes-wolf johannes-wolf force-pushed the some-mark-fixes branch 2 times, most recently from 89c2057 to 00fcb27 Compare November 12, 2023 19:36
@johannes-wolf johannes-wolf marked this pull request as draft November 15, 2023 05:31
@johannes-wolf johannes-wolf force-pushed the some-mark-fixes branch 7 times, most recently from acd6179 to d82bdfe Compare November 16, 2023 03:24
@johannes-wolf johannes-wolf marked this pull request as ready for review November 16, 2023 03:35
@johannes-wolf johannes-wolf force-pushed the some-mark-fixes branch 3 times, most recently from dbfbcdc to 2f3c900 Compare November 18, 2023 06:57
@johannes-wolf johannes-wolf added this to the 0.2 milestone Nov 20, 2023
@johannes-wolf johannes-wolf changed the title Some Mark Features mark: Some Mark Features Nov 20, 2023
@johannes-wolf johannes-wolf changed the base branch from 0.2.0 to improve-point-on-path November 20, 2023 23:42
Base automatically changed from improve-point-on-path to 0.2.0 November 22, 2023 18:16
@fenjalien fenjalien mentioned this pull request Dec 9, 2023
Closed
6 tasks
@johannes-wolf johannes-wolf mentioned this pull request Dec 16, 2023
Merged
johannes-wolf added a commit that referenced this pull request Dec 20, 2023
@johannes-wolf
transform: Add option for setting the origin (#407)
2abf154 
I think having the option to specify the rotation/scale origin can be
_very_ helpful.

(Finally fixes the grid bug, that I already fixed in #333).
@johannes-wolf
Copy link
Member Author

Closing if favor of #416.

@fenjalien fenjalien deleted the some-mark-fixes branch September 6, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenjalien fenjalien Awaiting requested review from fenjalien

Assignees
No one assigned
Labels
core:draw ✏️ core:styling enhancement ⬆️ New feature or request
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.
1 participant
@johannes-wolf