Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docs for projects/trust Namespace Selector feature #1038

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Adds docs for projects/trust Namespace Selector feature #1038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion content/docs/projects/trust.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,27 @@ spec:
-----END CERTIFICATE-----
target:
# Data synced to the ConfigMap `my-org.com` at the key `root-certs.pem` in
# every namespace.
# every namespace that has the label "linkerd.io/inject=enabled".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: it might be worth adding this to content/next-docs/projects/trust.md as well, but that only matters if this PR goes in before 1.9 and even then it'll be pretty simple for the releaser to fix!

configMap:
key: "root-certs.pem"
namespaceSelector:
matchLabels:
linkerd.io/inject: "enabled"
```

Bundle currently supports the source types `configMap`, `secret` and `inLine`,
and target type `configMap`.

#### Namespace Selector

The target `namespaceSelector` can be used for scoping which Namespaces targets
are synced to, supporting the field `matchLabels`. Please see
[here](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors)
for more information and how label selectors are configured.

If `namespaceSelector` is empty, a bundle target will be synced to all
Namespaces.
Comment on lines +64 to +70
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): a rewording which maybe reads a little smoother and voids a link called "here"; what do you think?

Suggested change
The target `namespaceSelector` can be used for scoping which Namespaces targets
are synced to, supporting the field `matchLabels`. Please see
[here](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors)
for more information and how label selectors are configured.
If `namespaceSelector` is empty, a bundle target will be synced to all
Namespaces.
The `namespaceSelector` field in a target reduces the set of Kubernetes namespaces to which that target is synced.
Label selectors are detailed in the [Kubernetes documentation](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors).
If `namespaceSelector` is empty, a bundle target will be synced to all namespaces.


---

## Installation
Expand Down