Adds docs for projects/trust Namespace Selector feature #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joshvanl <[email protected]>
jetstack-bot
added
do-not-merge/hold
jetstack-bot
added
the
approved
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SgtCoDFish
approved these changes
Jul 20, 2022
Comment on lines
+64
to
+70
| The target `namespaceSelector` can be used for scoping which Namespaces targets | ||
| are synced to, supporting the field `matchLabels`. Please see | ||
| [here](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors) | ||
| for more information and how label selectors are configured. | ||
|
|
||
| If `namespaceSelector` is empty, a bundle target will be synced to all | ||
| Namespaces. |
There was a problem hiding this comment.
suggestion (non-blocking): a rewording which maybe reads a little smoother and voids a link called "here"; what do you think?
Suggested change
| The target `namespaceSelector` can be used for scoping which Namespaces targets | |
| are synced to, supporting the field `matchLabels`. Please see | |
| [here](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors) | |
| for more information and how label selectors are configured. | |
| If `namespaceSelector` is empty, a bundle target will be synced to all | |
| Namespaces. | |
| The `namespaceSelector` field in a target reduces the set of Kubernetes namespaces to which that target is synced. | |
| Label selectors are detailed in the [Kubernetes documentation](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors). | |
| If `namespaceSelector` is empty, a bundle target will be synced to all namespaces. |
| # every namespace. | ||
| # every namespace that has the label "linkerd.io/inject=enabled". |
There was a problem hiding this comment.
nitpick: it might be worth adding this to content/next-docs/projects/trust.md as well, but that only matters if this PR goes in before 1.9 and even then it'll be pretty simple for the releaser to fix!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold The feature itself has merged now; no real reason to delay this going in! |
jetstack-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code PR
/hold
Until code PR is merged an in a release.