Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to install openshift-routes in a different namespace than "cert-manager" using oc process #40

Closed
wants to merge 5 commits into from

Conversation

maelvls
Copy link
Member

@maelvls maelvls commented Sep 15, 2023

This is a continuation of #32. This PR focuses on a very precise request coming from people relying on the oc process command to substitute variables such as $NAMESPACE in the static manifest.

To test this PR, run the following:

oc process -f https://raw.githubusercontent.com/maelvls/openshift-routes/different-namespace/deploy/static/cert-manager-openshift-routes.yaml \
  -p NAMESPACE=<NAMESPACE_NAME> \
  | oc create -f -

Just for consistency with interpolation tools such as 'subst' and 'oc
process'.
kube-system is always present in every cluster, unlike the
"cert-manager" namespace. The reason we want a central namespace is that
we want to avoid mistakenly creating two replicas (in the same pod, or
in different pods across namespaces) of openshift-routes.
@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 15, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maelvls. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2023
@jetstack-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 765e6e0 make it possible to install to a different namespace
  • bd7fc5b deploy/static: use '${RELEASED_VERSION}' instead of '$RELEASED_VERSION'
  • e7057ab deploy/static: introduce '${NAMESPACE}'
  • effea4c deploy/static: use kube-system as the default election namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2023
@jetstack-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maelvls maelvls changed the title Make it possible to install openshift-routes in a different namespace than "cert-manager" Make it possible to install openshift-routes in a different namespace than "cert-manager" with oc install May 31, 2024
@maelvls maelvls changed the title Make it possible to install openshift-routes in a different namespace than "cert-manager" with oc install Make it possible to install openshift-routes in a different namespace than "cert-manager" using oc process May 31, 2024
@cert-manager-prow
Copy link
Contributor

@maelvls: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-openshift-routes-smoke 457b447 link true /test pull-cert-manager-openshift-routes-smoke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maelvls
Copy link
Member Author

maelvls commented Jul 19, 2024

Closing as I wasn't able to find the time to finish this. Please feel free to take over!

@maelvls maelvls closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants