-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to install openshift-routes in a different namespace than "cert-manager" using oc process
#40
Conversation
Just for consistency with interpolation tools such as 'subst' and 'oc process'.
kube-system is always present in every cluster, unlike the "cert-manager" namespace. The reason we want a central namespace is that we want to avoid mistakenly creating two replicas (in the same pod, or in different pods across namespaces) of openshift-routes.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Maël Valais <[email protected]>
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
oc install
oc install
oc process
@maelvls: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Closing as I wasn't able to find the time to finish this. Please feel free to take over! |
This is a continuation of #32. This PR focuses on a very precise request coming from people relying on the
oc process
command to substitute variables such as$NAMESPACE
in the static manifest.To test this PR, run the following: