Allow installation in a custom namespace

[poponealex]

This PR solves the issue #30.

[maelvls]

Hey! Thank you for the great work. I will take a look at the PR on Monday. Thanks!

Note: I'll be on PTO from Tue 27 June to Sun 23 July. Please ping another maintainer (such as @inteon) if you need a quicker review.

[jetstack-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: poponealex
Once this PR has been reviewed and has the lgtm label, please assign meyskens for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[maelvls]

Hey, thanks for submitting this PR!

It looks like the namespace configured with the new env var CERT_MANAGER_NAMESPACE is only every used by the openshift-routes process for configuring the leader election namespace with --leader-election-namespace. I am a bit confused as to why the default is cert-manager, I think it should be kube-system to prevent two instances of openshift-routes from mistakenly fighting over the reconciliation as explained in cert-manager/cert-manager#4102. Reading cert-manager/cert-manager#4102 made me realize that kube-system is not ideal for many people, so defaulting to cert-manager kind of makes sense.

That said, why introduce the env var CERT_MANAGER_NAMESPACE when we can just use the --leader-election-namespace flag directly:

containers:
  - name: cert-manager-openshift-routes
    image: "ghcr.io/cert-manager/cert-manager-openshift-routes:$RELEASED_VERSION"
    args:
    - -v=5
    - --leader-election-namespace=${CERT_MANAGER_NAMESPACE}

Does it make sense?

[poponealex]

Hey, thanks for your reply!

Why would one need multiple instances of openshift-routes?

Yeah it does actually make a lot of sense to use the --leader-election-namespace flag. I just wasn't aware that it existed (it isn't documented) and since I'm not knowledgeable in Go and I skim read the code I didn't catch that.

Anyway, I won't be using openshift-routes because of other issues. Hence, I developed my own controller: github.com/its4u/cert-manager-routes-controller.

[maelvls]

Hey Alexandre,

I am sorry to hear that this project didn't fit you needs 😞

I am impressed to see that you chose to use Rust for github.com/its4u/cert-manager-routes-controller. Not that many projects went down this path, and I think it shows your dedication! Your README is also excellent.

I am hoping we can get a proper way of shipping the manifest, e.g., an OLM package or a Helm chart. That should drastically improve the experience and enable changing the namespace.

[maelvls]

I'll close this PR for now. I hope that makes sense! Feel free to re-open if you decide to continue working on this.