This repository has been archived by the owner on May 24, 2024. It is now read-only.
[ModalManager, DisclosureManagerContext] Adding helpful doc for modal sizes #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessieRandle
temporarily deployed
to
terra-applic-disclose-m-nadk0w
JessieRandle
temporarily deployed
to
terra-applic-disclose-m-nadk0w
JessieRandle
temporarily deployed
to
terra-applic-disclose-m-nadk0w
neilpfeiffer
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Tested: PR #309
Resolves: Issue terra-framework #567 and UXPLATFORM-6896
Reviewed:
- Update includes helpful explanation for consumers of the various size options for modals in Terra, guidance as to how content should be created, plus the reasons and benefits as to why heights for modals are static, as opposed to being dynamic (based on inner-content) as might be expected like alternative UI frameworks.
| UX Reviewed |
|---|
neilpfeiffer
changed the title
neilpfeiffer
changed the title
neilpfeiffer
changed the title
neilpfeiffer
changed the title
This was referenced Sep 23, 2022
Closed
supreethmr
approved these changes
Sep 26, 2022
JessieRandle
temporarily deployed
to
terra-applic-disclose-m-nadk0w
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding helpful documentation for the intentional static height technical design & implementation used in ModalManager via DisclosureManagerContext.
Closes terra-framework:issue#567 and UXPLATFORM-6896
Also resolves missing documentation needed as to reasons for closing terra-framework:issue#559(comment).
Deployment Link
https://terra-applic-disclose-m-nadk0w.herokuapp.com/application/terra-application/components/modal-manager
Additional Details
cc: @dkasper-was-taken @nickpith @chrismichalewicz