This repository has been archived by the owner on May 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kenk2
approved these changes
May 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
main
(terra-app v1) andmain-terra-app-v2.1
(terra-app v2) branches have diverged quite a bit over the years. Now that terra-application v2 is ready to be officially released & deployed, this PR pulls in changes from #293 to combine both these branches. Some additional changes were made such as upgrading dependencies to react-intl v5 & fixing wdio tests, but most of the changes in the PR were done as part of these terra-application-v2 PRs:backup branch and tag:
branch: https://github.com/cerner/terra-application/tree/terra-application-v1
tag: https://github.com/cerner/terra-application/releases/tag/terra-application-v1.58
Testing
This change was tested using:
This was also tested by installing locally in orion-application and successfully running tests.
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
Thank you for contributing to Terra.
@cerner/terra