Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Sync with terra app v2 #378

Merged
merged 37 commits into from
May 1, 2024
Merged

Sync with terra app v2 #378

merged 37 commits into from
May 1, 2024

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Apr 25, 2024

Summary

The main (terra-app v1) and main-terra-app-v2.1 (terra-app v2) branches have diverged quite a bit over the years. Now that terra-application v2 is ready to be officially released & deployed, this PR pulls in changes from #293 to combine both these branches. Some additional changes were made such as upgrading dependencies to react-intl v5 & fixing wdio tests, but most of the changes in the PR were done as part of these terra-application-v2 PRs:

backup branch and tag:

branch: https://github.com/cerner/terra-application/tree/terra-application-v1
tag: https://github.com/cerner/terra-application/releases/tag/terra-application-v1.58

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

This was also tested by installing locally in orion-application and successfully running tests.

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this Apr 25, 2024
@sdadn sdadn marked this pull request as ready for review April 25, 2024 21:59
Copy link
Contributor

@adoroshk adoroshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Screenshot 2024-05-01 at 11 08 05 AM
Screenshot 2024-05-01 at 11 08 30 AM

@sdadn sdadn merged commit bf6426a into main May 1, 2024
6 checks passed
@sdadn sdadn deleted the sync-with-terra-app-v2 branch May 1, 2024 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants