Add TLS support #792
Closed
Add TLS support #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epuertat
requested changes
Aug 8, 2024
There was a problem hiding this comment.
Thanks a log, Gil, for your work here.
Most of it is ok, but I left a few comments on improvements, and my main concern is about the service creating directories on its own. If that's inside the container, they should rather be created at container build or run via mounts/volumes.
These dirs should be provided externally, and tracked by the package manager/orchestrator.
gbregman
force-pushed
the
devel
branch
2 times, most recently
from
5eb7c97 to
c9608ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.