Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create a directory in the container #794

Closed
gbregman opened this issue Aug 9, 2024 · 0 comments · Fixed by #810
Closed

Do not create a directory in the container #794

gbregman opened this issue Aug 9, 2024 · 0 comments · Fixed by #810
Assignees
@gbregman

Comments

@gbregman
Copy link
Contributor

gbregman commented Aug 9, 2024

Right now we create a directory for the SPDK socket file in the gateway code. This should be done externally and not in the code.
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Aug 9, 2024
@gbregman gbregman self-assigned this Aug 9, 2024
@gbregman gbregman mentioned this issue Aug 9, 2024
Closed
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Aug 20, 2024
@gbregman
Revert SPDK sokcer path to /var/tmp/spdk.sock.
b747292 
Fixes ceph#794

Signed-off-by: Gil Bregman <[email protected]>
@gbregman gbregman mentioned this issue Aug 20, 2024
Merged
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Aug 20, 2024
@gbregman
Revert SPDK sokcet path to /var/tmp/spdk.sock.
0897a3c 
Fixes ceph#794

Signed-off-by: Gil Bregman <[email protected]>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Aug 20, 2024
@gbregman
Revert SPDK sokcet path to /var/tmp/spdk.sock.
c25f87d 
Fixes ceph#794

Signed-off-by: Gil Bregman <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert SPDK sokcet path to /var/tmp/spdk.sock gbregman/ceph-nvmeof
1 participant
@gbregman