-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase: workaround missing redirect #1370
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
/test ci/centos/containerized-tests |
1 similar comment
/test ci/centos/containerized-tests |
/test all |
/test ci/centos/containerized-tests |
/retest ci/centos/containerized-tests |
E2E is catching the issue which is corrected by #1368 ... Does the PR need rebasing?
|
@Mergifyio rebase |
This fix is needed because we were hitting: ``` vbom.ml/[email protected]: unrecognized import path "vbom.ml/util": reading https://vbom.ml/util?go-get=1: 503 Service Unavailable ``` Source for the workaround: golang/dep#1169 The fix consists in simply enforcing what the redirect was supposed to do. Signed-off-by: Madhu Rajanna <[email protected]>
Command
|
running: go mod verify https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/containerized-tests/324/console |
/retest all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this really not include any changed files under vendor/
? that is hard to believe
No it doesn't include any file changes in vendor directory , can you please test it out locally if am missing anything |
In that case I expect ci to fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, tested it locally and the changes match what I have
This fix is needed because we were hitting:
Source for the workaround:
golang/dep#1169
The fix consists in simply enforcing what the redirect was supposed to do.
Signed-off-by: Madhu Rajanna [email protected]