Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase: workaround missing redirect #1370

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Aug 12, 2020

This fix is needed because we were hitting:

vbom.ml/[email protected]:
unrecognized import path "vbom.ml/util":
reading https://vbom.ml/util?go-get=1: 503 Service Unavailable

Source for the workaround:
golang/dep#1169

The fix consists in simply enforcing what the redirect was supposed to do.
Signed-off-by: Madhu Rajanna [email protected]

@ghost
Copy link

ghost commented Aug 12, 2020

There were the following issues with this Pull Request

  • Commit: 4808e23
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@Madhu-1 Madhu-1 changed the title go.mod: workaround missing redirect rebase: workaround missing redirect Aug 12, 2020
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/test ci/centos/containerized-tests

1 similar comment
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/test ci/centos/containerized-tests

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/test all

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/test ci/centos/containerized-tests

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/retest ci/centos/containerized-tests

@Yuggupta27
Copy link
Contributor

Yuggupta27 commented Aug 12, 2020

E2E is catching the issue which is corrected by #1368 ... Does the PR need rebasing?

internal/rbd/rbd_util.go:629:51: undefined: csiConfigFile
internal/rbd/rbd_util.go:713:51: undefined: csiConfigFile 

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

@Mergifyio rebase

This fix is needed because we were hitting:
```
vbom.ml/[email protected]:
unrecognized import path "vbom.ml/util":
reading https://vbom.ml/util?go-get=1: 503 Service Unavailable
```

Source for the workaround:
golang/dep#1169

The fix consists in simply enforcing what the redirect was supposed to
do.

Signed-off-by: Madhu Rajanna <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2020

Command rebase: success

Branch has been successfully rebased

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

@humblec @nixpanic containerized tests passed 🥳

@Madhu-1 Madhu-1 requested review from nixpanic and humblec and removed request for nixpanic August 12, 2020 15:39
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

�[1;36mSummary:�[0m
Files: 53
Lines: 13046
Nosec: 18
Issues: �[1;32m0�[0m

running: go mod verify
all modules verified

https://jenkins-ceph-csi.apps.ocp.ci.centos.org/job/containerized-tests/324/console

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/retest all

Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this really not include any changed files under vendor/? that is hard to believe

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

does this really not include any changed files under vendor/? that is hard to believe

No it doesn't include any file changes in vendor directory , can you please test it out locally if am missing anything

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

does this really not include any changed files under vendor/? that is hard to believe

In that case I expect ci to fail

Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested it locally and the changes match what I have

@mergify mergify bot merged commit 22158eb into ceph:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants