Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: fix build issue for rbd #1368

Merged
merged 1 commit into from
Aug 12, 2020
Merged

rbd: fix build issue for rbd #1368

merged 1 commit into from
Aug 12, 2020

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Aug 12, 2020

merging of #1035 broken the cephcsi building. This commits fixes the build issue.

Signed-off-by: Madhu Rajanna [email protected]

merging of ceph#1035
broken the cephcsi building. This commits fixes
the build issue.

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1 Madhu-1 mentioned this pull request Aug 12, 2020
@humblec humblec added this to the release-3.1.0 milestone Aug 12, 2020
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/test all

@humblec
Copy link
Collaborator

humblec commented Aug 12, 2020

@Madhu-1 @nixpanic still contenarized tests are failing.. :(

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/retest ci/centos/containerized-tests

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

@Madhu-1 @nixpanic still contenarized tests are failing.. :(

i don't see failure in Jenkins logs. restarted once again to check

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/test ci/centos/containerized-tests

@nixpanic
Copy link
Member

@Madhu-1 @nixpanic still contenarized tests are failing.. :(

@humblec Can you share the errors or link to the output?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

running: go mod verify
go: k8s.io/[email protected] requires
vbom.ml/[email protected]: unrecognized import path "vbom.ml/util": reading https://vbom.ml/util?go-get=1: 503 Service Unavailable
ERROR: go.mod was modified by 'go mod verify'

503 error

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/retest ci/centos/containerized-tests

@humblec
Copy link
Collaborator

humblec commented Aug 12, 2020

This is crazy.. :(

@humblec
Copy link
Collaborator

humblec commented Aug 12, 2020

@Madhu-1 @nixpanic can we go ahead with the manual merge ?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/retest ci/centos/containerized-tests

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

@Madhu-1 @nixpanic can we go ahead with the manual merge ?

restarted containerized tests. even if we merge this PR other PR's might going to fail at same stage

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/test ci/centos/containerized-tests

@humblec
Copy link
Collaborator

humblec commented Aug 12, 2020

@Madhu-1 @nixpanic can we go ahead with the manual merge ?

restarted containerized tests. even if we merge this PR other PR's might going to fail at same stage

@Madhu-1 as we have the other Doc PRs got passed from Travis , we are good , Isnt it ?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

@Madhu-1 @nixpanic can we go ahead with the manual merge ?

restarted containerized tests. even if we merge this PR other PR's might going to fail at same stage

@Madhu-1 as we have the other Doc PRs got passed from Travis , we are good , Isnt it ?

Make sure PR is rebased and Travis CI passes then we can merge the doc PR's

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

/retest ci/centos/containerized-tests

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

go: k8s.io/[email protected] requires
vbom.ml/[email protected]: unrecognized import path "vbom.ml/util": reading https://vbom.ml/util?go-get=1: 503 Service Unavailable
ERROR: go.mod was modified by 'go mod verify'

again it is failing with same error

@humblec
Copy link
Collaborator

humblec commented Aug 12, 2020

lets merge ? @Madhu-1

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 12, 2020

lets merge ? @Madhu-1

Yes lets merge as E2E and static check is passed in Travis CI

@Madhu-1 Madhu-1 merged commit 8a581ec into ceph:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants