core: bump to ansible 2.15 #7492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
force-pushed
the
bump-ansible-2.15
branch
7 times, most recently
from
390bf2f to
02d8fa6
Compare
|
Wouldn't it make sense to go straight to 2.16? |
let's bump the python version to 3.10 in python-based github actions. Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit 66337a3)
typical error:
```
Error: raise NotImplementedError('an AnsibleCollectionFinder has not been installed in this process')
NotImplementedError: an AnsibleCollectionFinder has not been installed in this process
```
Signed-off-by: Guillaume Abrioux <[email protected]>
This fixes the following error: ``` syntax-check[specific]: The field 'hosts' has an invalid value, which includes an undefined variable. ``` Signed-off-by: Guillaume Abrioux <[email protected]>
this is a dirty and temporary hack so we just list error and make this job success anyway. Signed-off-by: Guillaume Abrioux <[email protected]>
guits
force-pushed
the
bump-ansible-2.15
branch
from
8cdd661 to
8f29879
Compare
it might make sense, yes. (keep in mind this is for stable-7.0) |
guits
force-pushed
the
bump-ansible-2.15
branch
from
8f29879 to
b339af9
Compare
Ah, I thought that was for the stable-8.0. For stable-7.0 I think Ansible 2.15 is fully sufficient. We have been using stable-7.0 with Ansible 2.14 for a long time without any problems. |
guits
force-pushed
the
bump-ansible-2.15
branch
2 times, most recently
from
ee8bb68 to
43a075f
Compare
2.12 is EOL since May 2023. Let's bump to 2.15. Signed-off-by: Guillaume Abrioux <[email protected]>
rbd-mirror tests are using devel packages while it should use quincy. Signed-off-by: Guillaume Abrioux <[email protected]>
With ansible-core 2.15 it is not possible to pass argument of unexpected type, as otherwise module will fail with: `'None' is not a string and conversion is not allowed` With that we want to only get all existing crush rules, so we can simply supply an empty string as a name argument, which would satisfy requirements and have same behaviour for previous ansible versions. Alternative approach would be to stop making `name` as a required argument to the module and use empty string as default value when info state is used. Signed-off-by: Dmitriy Rabotyagov <[email protected]> (cherry picked from commit b610297)
This refactor makes the 'name' argument not mandatory because when 'state' is 'info' we shouldn't need to pass it. The second change is just a duplicate code removal. Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit e433d2b)
this makes the scenario use devel rpms which is wrong. Signed-off-by: Guillaume Abrioux <[email protected]>
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit 37a8222)
This is needed for new instances are the restart might trigger before the deployment Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit 7142321)
Signed-off-by: Seena Fallah <[email protected]>
guits
force-pushed
the
bump-ansible-2.15
branch
from
43a075f to
cdce2ce
Compare
|
jenkins test centos-container-all_daemons |
- the collection path isn't right - vagrant_up.sh fails because the path isn't passed down - increase the number of retries and delay for pytest Signed-off-by: Guillaume Abrioux <[email protected]>
Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit 1a97696)
guits
force-pushed
the
bump-ansible-2.15
branch
from
99fb1f6 to
3ec773a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.12 is EOL since May 2023.
Let's bump to 2.15.