Ansible: Fix for missing group names in get_variables() #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry to tag you @philpep, this should be a quick fix, otherwise I need to monkey patch the fix in my code and I'd rather not. Basically it didn't list all the groups the way ansible does it (by including all the groups it is part of, not just the direct parents). This allows to load the ansible variables the way they should be loaded (by loading the top parents, then overriding by loading the children of the top parent, then by the children of the children). Thanks in advance. |
|
Hi, LGTM, can you also fix the two related broken tests ? https://github.com/pytest-dev/pytest-testinfra/actions/runs/5765772823/job/16193366140?pr=724 Thanks! |
|
@philpep Done! |
|
Merged, thanks! |
|
Hi, just wondering if you know when there'll be a release with the fix (maybe 9.0.1?), we're currently using a monkey patch as a workaround on our side, but we'd much prefer not to! Thanks in advance |
asm0deuz
added a commit
to asm0deuz/ceph-ansible
that referenced
this pull request
Jan 15, 2024
pytest-infra 10.0.0 release (pytest-dev/pytest-testinfra#724) changed the get_variables() behavior which led to CI failures Signed-off-by: Teoman ONAY <[email protected]>
asm0deuz
added a commit
to asm0deuz/ceph-ansible
that referenced
this pull request
Jan 15, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]>
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Feb 13, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]>
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Feb 13, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]>
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Feb 13, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]>
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Feb 13, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]>
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Feb 13, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]>
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Feb 14, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]>
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Mar 9, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit 37a8222)
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Mar 10, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit 37a8222)
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Mar 10, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit 37a8222)
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Mar 10, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit 37a8222)
guits
pushed a commit
to ceph/ceph-ansible
that referenced
this pull request
Mar 11, 2024
pytest-infra 10.0.0 release changed the get_variables() behavior which led to CI failures (pytest-dev/pytest-testinfra#724) Starting of now all groups the host is part of and not only the direct parent groups are returned by get_variables() Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit 37a8222)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ansible variable group names contains all groups the host is part of and not only the direct parent groups, this is a fix to reflect how ansible works.
Link to documentation: