Upgrade opencensus-proto version to v0.2.0.

[songy23]

No description provided.

[odeke-em]

At long last, it has finally been released :) LGTM and thank you @songy23! If you run GO111MODULE=on go mod tidy it should also remove the old opencensus-proto v0.1.* entry in go.sum

[songy23]

If you run GO111MODULE=on go mod tidy it should also remove the old opencensus-proto v0.1.* entry in go.sum

Looks like it removed something else. Could it be due to other indirect dependency on v0.1.0 proto?

[odeke-em]

Looks like it removed something else. Could it be due to other indirect dependency on v0.1.0 proto?

I think it is because of the Prometheus metrics exporter and receiver that were pinned to v0.1.0*

[odeke-em]

I've pushed up orijtech/promreceiver@69e7d86 and now going to do the same for the prometheus-metrics-exporter. Once those no longer take that proto dependency, we'll be clear. Obviously this is temporary and will change once they are merged in here when #479 and #481 are merged!

[odeke-em]

@songy23 now if you just do GO111MODULE=on go get github.com/orijtech/[email protected] and then finally GO111MODULE=on go mod tidy all should now be cleared as promreceiver is now bumped up to use OpenCensus-Proto v0.2.0

[odeke-em]

Also there is a legit failure from the opencensus-proto/gen-go files

# github.com/census-instrumentation/opencensus-proto/gen-go/agent/common/v1
../../../../pkg/mod/github.com/census-instrumentation/[email protected]/gen-go/agent/common/v1/common.pb.go:22:11: undefined: proto.ProtoPackageIsVersion3
# github.com/census-instrumentation/opencensus-proto/gen-go/resource/v1
../../../../pkg/mod/github.com/census-instrumentation/[email protected]/gen-go/resource/v1/resource.pb.go:21:11: undefined: proto.ProtoPackageIsVersion3

[songy23]

v0.4.0 not found:

$ GO111MODULE=on go get github.com/orijtech/[email protected]
go: finding github.com/orijtech/promreceiver v0.4.0
go get github.com/orijtech/[email protected]: unknown revision v0.4.0

Also there is a legit failure from the opencensus-proto/gen-go files

Looking

[odeke-em]

Hmm, that's odd as I published it 1+ hour ago https://github.com/orijtech/promreceiver/releases/tag/v0.0.4 but perhaps you might need to add -u to update your version but really go mod should do it for you.

[odeke-em]

@songy23 I just noticed, we'll also need to update the opencensus-exporters-{ocagent, stackdriver}
I've mailed so far: census-ecosystem/opencensus-go-exporter-ocagent#48

[songy23]

Also there is a legit failure from the opencensus-proto/gen-go files

Seems to be the same issue to golang/protobuf#763.

[songy23]

Also there is a legit failure from the opencensus-proto/gen-go files

3391b6c resolved this. Now we need to update OC-Go Stackdriver exporter (census-ecosystem/opencensus-go-exporter-stackdriver#102) and OC-Agent exporter (census-ecosystem/opencensus-go-exporter-ocagent#48) to use the new oc-proto release.

[songy23]

if you just do GO111MODULE=on go get github.com/orijtech/[email protected]

Hmm, that's odd as I published it 1+ hour ago https://github.com/orijtech/promreceiver/releases/tag/v0.0.4 but perhaps you might need to add -u to update your version but really go mod should do it for you.

Updated. This should be 0.0.4 instead of 0.4.0.

[pjanotti]

It still has issues on Travis https://travis-ci.org/census-instrumentation/opencensus-service/builds/505609648#L1012-L1018

# github.com/orijtech/prometheus-go-metrics-exporter
../../../../pkg/mod/github.com/orijtech/[email protected]/prometheus.go:131:17: metric.GetName undefined (type *"github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric has no field or method GetName)
# github.com/orijtech/promreceiver
../../../../pkg/mod/github.com/orijtech/[email protected]/buffering.go:144:3: unknown field 'Descriptor_' in struct literal of type "github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric
# github.com/census-instrumentation/opencensus-service/receiver/opencensusreceiver/ocmetrics [github.com/census-instrumentation/opencensus-service/receiver/opencensusreceiver/ocmetrics.test]
receiver/opencensusreceiver/ocmetrics/opencensus_test.go:436:3: unknown field 'Descriptor_' in struct literal of type "github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric

[odeke-em]

Roger that @pjanotti! @songy23 if you update with GO111MODULE=on go get github.com/orijtech/[email protected] it should be good to go now. I had to also go adjust to the breaking OpenCensus-Proto changes but now should be all golden.

[codecov]

Codecov Report

Merging #490 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
- Coverage   57.24%   57.17%   -0.08%     
==========================================
  Files          68       68              
  Lines        4175     4175              
==========================================
- Hits         2390     2387       -3     
- Misses       1632     1635       +3     
  Partials      153      153

Impacted Files	Coverage Δ
receiver/opencensusreceiver/opencensus.go	61.81% <0%> (-2.73%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953218b...b62856d. Read the comment docs.

[songy23]

@odeke-em @pjanotti @bogdandrutu All build failures and most test failures are fixed. CI is green now. Follow-up items are tracked in #492. Thanks for the review and help!