Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

receiver/prometheus: migrate code in here #481

Closed
wants to merge 1 commit into from
Closed

receiver/prometheus: migrate code in here #481

wants to merge 1 commit into from

Conversation

odeke-em
Copy link
Member

@odeke-em odeke-em commented Mar 7, 2019

Hand over prometheus exporter code that I had
parked in https://github.com/orijtech/promreceiver

That code was written for OpenCensus Authors, and was just
waiting for a final destination. This change finishes that.

Fixes #480

@odeke-em odeke-em requested a review from a team as a code owner March 7, 2019 19:34
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #481 into master will increase coverage by 0.46%.
The diff coverage is 82.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   57.02%   57.49%   +0.46%     
==========================================
  Files          69       68       -1     
  Lines        4247     4759     +512     
==========================================
+ Hits         2422     2736     +314     
- Misses       1666     1844     +178     
- Partials      159      179      +20
Impacted Files Coverage Δ
receiver/prometheusreceiver/metrics_receiver.go 73.46% <100%> (ø) ⬆️
receiver/prometheusreceiver/buffering.go 100% <100%> (ø)
receiver/prometheusreceiver/options.go 66.66% <66.66%> (ø)
receiver/prometheusreceiver/receiver.go 80.15% <80.15%> (ø)
...servability/observabilitytest/observabilitytest.go 0% <0%> (-100%) ⬇️
exporter/opencensusexporter/opencensus.go 48.21% <0%> (-3.64%) ⬇️
...al/collector/processor/nodebatcher/node_batcher.go 77.72% <0%> (-0.46%) ⬇️
cmd/occollector/app/collector/processors.go 0% <0%> (ø) ⬆️
exporter/exportertest/nop_exporter.go 100% <0%> (ø) ⬆️
exporter/loggingexporter/logging_exporter.go 100% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51944b6...631495d. Read the comment docs.

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: this PR is too huge to review, consider putting the parsing logic in a util file and have a separate PR for it first.

Hand over prometheus exporter code that I had
parked in https://github.com/orijtech/promreceiver

That code was written for OpenCensus Authors, and was just
waiting for a final destination. This change finishes that.

Fixes #480
@pjanotti
Copy link

Hi @odeke-em, I'm closing this PR since it is stale for some time and iirc was superseded by other (later closed), let's know if that is not correct.

@pjanotti pjanotti closed this Jun 12, 2019
@odeke-em odeke-em deleted the bring-in-prometheus-receiver branch March 23, 2020 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

receiver/prometheus: bring in source code from Orijtech, Inc.
4 participants