Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

add resource detector test. #219

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Sep 16, 2019

fixes #218
It also changes for comments from PR #215 that were left out prior to merge.

@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #219 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   72.85%   73.02%   +0.16%     
==========================================
  Files          15       15              
  Lines        1599     1609      +10     
==========================================
+ Hits         1165     1175      +10     
  Misses        355      355              
  Partials       79       79
Impacted Files Coverage Δ
resource.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2798eee...46d33e7. Read the comment docs.

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default resource mapper maps additional label and doesn't check for missing labels
4 participants