Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Default resource mapper maps additional label and doesn't check for missing labels #218

Closed
rghetia opened this issue Sep 16, 2019 · 0 comments · Fixed by #219
Closed

Default resource mapper maps additional label and doesn't check for missing labels #218

rghetia opened this issue Sep 16, 2019 · 0 comments · Fixed by #219
Labels
bug Something isn't working

Comments

@rghetia
Copy link
Contributor

rghetia commented Sep 16, 2019

There are two issues with Default resource mapper

  1. It maps additional label . For example, if container_name is present but the resource type is k8s_pod then adds container_name. This would result into error on SD backend.
  2. If a label is missing for a particular resource type it should map to Global resource type. But it doesn't.
@rghetia rghetia added the bug Something isn't working label Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant