Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Don't overwrite agent label if already set #132

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

draffensperger
Copy link
Contributor

This will enable the OpenCensus service to write the g.co/agent label based on the library information of the written traces. Currently all trace written by the OC agent/collector have their agent set to look like they are using the Go library.

See census-instrumentation/opencensus-service#525 for context.

@draffensperger
Copy link
Contributor Author

@songy23 or @bogdandrutu could you review this? (I don't seem to be able to set the reviewers myself.)

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 merged commit 4351271 into census-ecosystem:master Apr 16, 2019
@draffensperger draffensperger deleted the respect-agent-label branch April 16, 2019 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants